[#ZC-2889]: when the server returns a 201 with a payload, update the …#87
Closed
percious wants to merge 3 commits into
Closed
[#ZC-2889]: when the server returns a 201 with a payload, update the …#87percious wants to merge 3 commits into
percious wants to merge 3 commits into
Conversation
jjdelc
reviewed
Mar 16, 2026
| else: | ||
| # We have a progress_url, wait for completion | ||
| entity.wait_progress(r, progress_tracker) | ||
| elif r.status_code == 201 and r.payload and "body" in r.payload: |
Contributor
There was a problem hiding this comment.
In our API the 201 responses do not have a body. They are an empty body and Location header. This condition will never be True in our use.
if r.status_code == 201:
entity.refresh() # This should work because the `self` was set above. Triggers the correct GET request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entity with the information.