Efficient dataset variables for cube#86
Merged
Merged
Conversation
tiagocoutinho
commented
Jun 5, 2025
tiagocoutinho
commented
Contributor
- lazy fetch variables
- use cached variables when need to access dataset variables
- lazy fetch variables - use cached variables when need to access dataset variables
tiagocoutinho
force-pushed
the
fetch-cubes-performance
branch
from
7ddf49e to
419fcc3
Compare
tiagocoutinho
force-pushed
the
fetch-cubes-performance
branch
from
b3776cf to
3517fd5
Compare
tiagocoutinho
commented
Jun 6, 2025
| @classmethod | ||
| def setUpClass(cls): | ||
| cls.s = Session("not an email", "not a password", site_url="https://app.crunch.io/api/") | ||
| cls.r = cls.s.get("http://httpbin.org/headers") |
Contributor
Author
There was a problem hiding this comment.
We shouldn't rely on httpbin.org being online and replying with the answer we need.
I got multiple failures both locally and on github actions because the site was not online
jjdelc
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.