Skip to content

[wip]: upgrade node version to 20#898

Open
sbonasu wants to merge 5 commits into
CrowdStrike:mainfrom
sbonasu:update-node
Open

[wip]: upgrade node version to 20#898
sbonasu wants to merge 5 commits into
CrowdStrike:mainfrom
sbonasu:update-node

Conversation

@sbonasu

@sbonasu sbonasu commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@sbonasu sbonasu force-pushed the update-node branch 2 times, most recently from c5d6519 to a2ea509 Compare August 7, 2025 17:12
@sbonasu sbonasu changed the title feat!: upgrade node version to 22 feat!: upgrade node version to 20 Aug 7, 2025
Comment thread package.json
},
"engines": {
"node": ">=18.12"
"node": ">=20.19"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webdriverio needs min 20.19

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it might make sense to work on a WIP branch with node update + webdriverio first? That way we don’t have to use their restrictive node version if it doesn't work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use this branch for WIP

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial push generated lot of errors, like you said webdriverio upgrade needs work

@kellyselden kellyselden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind updating the node version in the README as well? It is pretty out of date.

@sbonasu sbonasu changed the title feat!: upgrade node version to 20 [wip]: upgrade node version to 20 Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants