Skip to content

chore: add cross platform integration tests #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellyselden wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −2
Open

chore: add cross platform integration tests #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e45d6c2
chore: add cross platform integration tests
Jun 9, 2022
b407383
chore: increase test timeout for mac
Jun 10, 2022
0f5afdd
chore: use node to invoke
Jun 11, 2022
23f72e8
chore: increase test timeout for windows
Jun 11, 2022
6f5478f
chore: support windows
Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
- windows-latest
node:
- 14

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint:md": "remark -f doc CONTRIBUTING.md README.md packages/*/README.md examples/*/README.md packages/lint/doc",
"release": "next release --default-branch main --scripts.precommit \"FALTEST_PRINT_VERSION=false yargs-help-output README.md --npm-script-name start && git add README.md\" --scripts.postbump \"\\\"$PWD/scripts/postbump.js\\\"\" --no-bump-in-range-dependencies",
"start": "faltest",
"test": "./scripts/run.js packages test",
"test": "node scripts/run.js packages test",
"test:acceptance": "mocha"
},
"repository": {
Expand Down
2 changes: 2 additions & 0 deletions packages/cli/test/acceptance/kill-orphans-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const exec = promisify(require('child_process').exec);
const { startWebDriver } = require('../../../remote/src');

describe(function() {
this.timeout(10e3);

it('works', async function() {
let webDriver = await startWebDriver({
overrides: {
Expand Down
8 changes: 7 additions & 1 deletion packages/cli/test/fixtures/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,10 @@

process.env.FALTEST_CONFIG_DIR = __dirname;

require('../../../../node_modules/.bin/faltest');
let bin = 'faltest';

if (process.platform === 'win32') {
bin += '.cmd';
}

require(`../../../../node_modules/.bin/${bin}`);