feat: add flagged describe#433
Open
victormejia wants to merge 3 commits into
Open
Conversation
Author
|
@kellyselden re-did the PR to cherry-pick Preston's changes, and added tests. Thanks! |
kellyselden
reviewed
Feb 9, 2021
| let stats = await this.runTests(); | ||
|
|
||
| expect(stats.passes).to.equal(1); | ||
| expect(stats.passes).to.equal(4); |
Contributor
There was a problem hiding this comment.
If it was working, I would expect this to be 2, not 4?
Author
There was a problem hiding this comment.
So before the tests I added, there was one describe with three specs in there, I suspected it was counting the successful describe group of specs.
Contributor
There was a problem hiding this comment.
It should be counting passed tests. Before your change, it was counting the test with '!flag1' because no flags were supplied in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.