Support IAR CID from existing secret#523
Open
pkill2913 wants to merge 1 commit into
Open
Conversation
pkill2913
force-pushed
the
iar-support-agent-cid-existing-secret
branch
from
19a10b9 to
1d3ebaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for providing Falcon Image Analyzer CID through an existing Kubernetes secret using
AGENT_CID.Previously, IAR supported
crowdstrikeConfig.existingSecretforAGENT_CLIENT_IDandAGENT_CLIENT_SECRET, but still required the CID throughcrowdstrikeConfig.cidorglobal.falcon.cid. This change allows the CID to come from thesame existing secret.
Changes
AGENT_CIDfrom the ConfigMap when CID is provided by an existing secret.crowdstrikeConfig.existingSecretorglobal.falconSecret.secretNameto satisfy CID configuration.falcon-image-analyzer:1.1.20->1.1.21falcon-platform:1.4.0->1.4.1Testing
helm templatewithcrowdstrikeConfig.existingSecrethelm templatewithglobal.falconSecret.secretNamehelm templatewith directcrowdstrikeConfig.cidhelm lint helm-charts/falcon-image-analyzerhelm lint helm-charts/falcon-platform