Code-review skill for pre-push self-review of correctness, data-flow, and test gaps#3
Open
prateekkathal wants to merge 1 commit into
Open
Code-review skill for pre-push self-review of correctness, data-flow, and test gaps#3prateekkathal wants to merge 1 commit into
prateekkathal wants to merge 1 commit into
Conversation
A self-review skill for your own changes before pushing — reviews the working diff or branch-vs-base for correctness, data-flow, concurrency, and consistency bugs, and flags test gaps. - code-review/SKILL.md: the review passes (ordered by yield), test-gap pass, precision filter, and structured output format - code-review/references/bug-catalog.md: scannable checklist + class index - Add root CLAUDE.md referencing AGENTS.md - README: add code-review to the skills table and single-skill install - gitignore local-only tooling/data under code-review/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
code-reviewskill: a pre-push self-review you run on your own changes before they go out. It reviews the working diff or branch-vs-base for correctness, data-flow, concurrency, and consistency bugs, and surfaces test gaps.Changes
code-review/SKILL.md— the review process: correctness passes ordered by yield, a test-gap pass, a precision filter to avoid false positives, and a structured output format.code-review/references/bug-catalog.md— a scannable 60-second checklist plus a frequency-ranked class index and false-positive patterns.CLAUDE.mdreferencingAGENTS.md, with the repo's public/generic working rule.README.md— addcode-reviewto the skills table and the single-skill install example..gitignore— keep local-only tooling and data undercode-review/out of the repo.Notes
Committed content is generic per the repo's public-use convention. The skill's correctness lens complements the existing
github-pr-reviewskill (self-review of your own diff vs. reviewing someone else's PR).Note
Low Risk
Documentation-only skill and README/metadata changes; no application runtime or security-sensitive code paths.
Overview
Adds a new
code-reviewagent skill for pre-push self-review of your own diff (uncommitted, branch-vs-base, orgh pr diff), positioned as the complement togithub-pr-review(collaborative review of someone else’s PR).code-review/SKILL.mddefines the workflow: how to pick the diff and base branch, read beyond hunks, a quality bar (DRY/consistency), correctness passes A–J (producer–consumer tracing, queue idempotency, failure paths, TypeORM null vs undefined, React cache/hooks, SQL/migrations, Nest wiring, security), mandatory test-gap analysis, a precision filter for false positives, and structured output (push verdict + 🔴/🟠/🟡/🔵 findings).code-review/references/bug-catalog.mdmirrors that content as a 60-second checklist, frequency-ranked bug classes, and false-positive patterns.Repo hygiene:
CLAUDE.mddocuments public/generic contribution rules and points atAGENTS.md;README.mdlists the skill and adds a single-skill install line;.gitignoreexcludes localcode-review/scripts/andcode-review/examples/so only distilled skill content is published.Reviewed by Cursor Bugbot for commit 98b5f65. Bugbot is set up for automated code reviews on this repo. Configure here.