Support dynamic multi origin selection and fix OPTIONS CORS flow#1146
Open
Sightem wants to merge 1 commit into
Open
Support dynamic multi origin selection and fix OPTIONS CORS flow#1146Sightem wants to merge 1 commit into
Sightem wants to merge 1 commit into
Conversation
Contributor
Author
|
This is quite old, i found the modifications locally when going through my projects folder. I vaguely recall going against some RFCs for cors, though I cannot fully remember. tests pass. |
Contributor
Author
|
This seems weird, i cant reproduce the error locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the CORS TODO for dynamic multi origin support and aligns middleware behavior with CORS expectations for credentialed requests and preflight handling, as well as fixing the request lifecycle so auto
OPTIONSresponses are finalized after headers are parsed, allowing CORS middleware to read Origin