🐛 auto-show main window on first launch for all desktop platforms - #4697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4696
Summary
On Windows and Linux the first launch showed no window at all: the main window starts hidden and the only first-launch auto-show call lived in the macOS tray view (
MacTrayView.Tray()). New users saw nothing but a (possibly overflow-collapsed) tray icon and perceived the app as "not opening".This PR lifts the first-launch logic into the platform-agnostic
CrossPasteWindowscomposable:firstLaunch && !firstLaunchCompleted→showMainWindow(WindowTrigger.SYSTEM)+setFirstLaunchCompleted(true)now runs on macOS, Windows, and LinuxMacTrayViewSide effect fixed
setFirstLaunchCompleted(true)was previously macOS-only, sofirstLaunchCompletedstayedfalseforever on Windows/Linux and the blinkingTutorialButton(gated onfirstLaunchCompleted && config.showTutorial) never appeared there. It now works on all platforms.Behavior notes
CrossPasteWindows, preserving the previous macOS ordering (tray init before window show)Testing
./gradlew ktlintFormatclean./gradlew app:compileKotlinDesktoppasses./gradlew app:desktopTestpasses