Fix PHPStan reported issues#109
Merged
Merged
Conversation
These started being flagged without code changes:
```log
Error: Property Crell\Serde\Attributes\ClassSettings::$omitNullFields (bool) on left side of ?? is not nullable.
Error: Match arm comparison between Crell\Serde\TypeCategory::StringEnum and Crell\Serde\TypeCategory::StringEnum is always true.
------ -----------------------------------------------------------------------
Line src/Attributes/Field.php
------ -----------------------------------------------------------------------
242 Property Crell\Serde\Attributes\ClassSettings::$omitNullFields (bool)
on left side of ?? is not nullable.
🪪 nullCoalesce.property
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/PropertyHandler/EnumExporter.php
------ -----------------------------------------------------------------------
56 Match arm comparison between Crell\Serde\TypeCategory::StringEnum and
Crell\Serde\TypeCategory::StringEnum is always true.
🪪 match.alwaysTrue
💡 Remove remaining cases below this one and this error will
disappear too.
------ -----------------------------------------------------------------------
```
6 tasks
Crell
approved these changes
Apr 29, 2026
Owner
|
Verified the issue locally as well. Looks like bug fixes in some recent PHPStan version. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and context
These PHPStan errors started being flagged without code changes:
The changes in this PR solve the new errors flagged under PHPStan version 2.1.51
How has this been tested?
Automated checks with
composer all-checks