feat(AprBreakdown): add visible focus-visible outline on interactive elements - #898
Open
waterWang wants to merge 1 commit into
Open
feat(AprBreakdown): add visible focus-visible outline on interactive elements#898waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…elements Move hardcoded :focus-visible styles from AprBreakdown.css to centralized focus.css, using shared design tokens. Changes: - Add AprBreakdown focus-visible rules to focus.css with shared --focus-ring-width, --focus-ring-color, --focus-ring-offset tokens - Remove hardcoded focus-visible rules from AprBreakdown.css - Add tests for AprBreakdown focus rules in focus.test.tsx Closes Creditra#835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add visible focus-visible outline on every interactive element in the AprBreakdown component, using the project's shared focus-ring design tokens.
Changes
.apr-breakdown__toggleand.apr-breakdown__component-expand, using shared--focus-ring-width,--focus-ring-color, and--focus-ring-offsettokens:focus-visiblerules (now handled by focus.css)Tests
Closes #835