feat(Breadcrumb): add middle-ellipsis label truncation with ellipsisThreshold prop - #897
Open
waterWang wants to merge 1 commit into
Open
feat(Breadcrumb): add middle-ellipsis label truncation with ellipsisThreshold prop#897waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…hreshold prop Add utility function that truncates long breadcrumb labels with a middle ellipsis (e.g. 'ABCDEFGHIJKLMNOP' -> 'ABCD…NOP'). - Add prop to Breadcrumb (default 30) - Apply middle-ellipsis truncation to individual labels that exceed the threshold - Add attribute with full text for accessibility - Support as alias for in BreadcrumbItem Closes Creditra#846
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #846
Summary
Add middle-ellipsis label truncation to the Breadcrumb component. When an individual breadcrumb label exceeds the configurable
ellipsisThreshold(default 30 chars), it is truncated with a middle ellipsis (e.g.ABCDEFGHIJKLMNOP→ABCD…NOP).Changes
middleEllipsisutility function for string truncationellipsisThresholdprop to Breadcrumb (default 30)titleattribute with full text for accessibilityhrefas alias fortoin BreadcrumbItemTests
src/components/__tests__/Breadcrumb.test.tsxpasssrc/components/Breadcrumb.test.tsxpass (no regressions)