[pull] main from stablyai:main#31
Merged
Merged
Conversation
…nit loop) (#5510) * fix(ports): stop live-port indicator flickering on transient scan failures A worktree's plug icon renders only when it has ports. The scanner polls each execution host every 30s and, on a transient failure (SSH/IPC latency), substituted an empty "unavailable" scan — dropping that host's ports for the cycle and blinking the affected row's live-port indicator off, then on again next poll. Debounce per-host failures: reuse the host's last good scan until failures reach a tolerance, so a single dropped poll no longer zeroes the row. A reachable host reporting no ports has no unavailableReason, so a genuine port close still clears immediately. Logic extracted to a pure helper with tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ports): stop port scan re-init loop that flickered live-port icons The scan poll effect depended on the `refresh` callback identity, which gets a fresh reference whenever repos/settings are replaced (frequent in a busy workspace). Each change re-ran the effect, which reset the scan to null and kicked an immediate re-scan — a tight ~600ms loop that blinked the plug icon off/on even though the scanned ports never changed. Drive the poll and advertised-url effects off the latest refresh via a ref and key them on stable value-signatures (enable state, active scan key, host-set signature, runtime kind) instead of the callback identity. Incidental store churn no longer re-inits the scanner; it still polls every 30s, reacts to advertised-url events, and rescans on a real host-set or runtime change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address PR review feedback (#5510) - Prune the per-host failure counter for failed-only hosts that disappear, not just hosts present in lastGood — avoids an unbounded failures map and a stale failure streak if the host reappears - Canonicalize scanTargetsSignature by sorting so a reordered-but-unchanged host set does not re-init the scan and reintroduce flicker Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ports): keep host scans targeted and stable * test(ports): cover scan debounce state --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
… addon patch (#8150) TextureAtlas.clearTexture() guarded on pages[0].currentRow being at the origin — but merged pages are never written through currentRow, so once a page merge lands a merged page at index 0, every atlas wipe for the rest of the session silently no-ops: no content clear, no glyph-cache clear, no clear-model generation bump. Recoveries degrade to placebo, the glyph cache grows unboundedly, and the session drifts into a merge-heavy state where stale vertex data paints the tiny-glyph garble seen after unfocus-then-paste into Claude Code. Fixes in @xterm/addon-webgl patch (lib bundles + readable src): - clearTexture(): guard on any-page-has-glyphs; restore _activePages after wiping (merges permanently shrink the active set) - AtlasPage.clear(): reset _glyphs/_usedPixels so wiped pages stop distorting merge-candidate selection - renderRows merge-retry loop: check the retry budget before beginFrame() so tripping the limit cannot consume the clear-model notification and strand a stale model - GlyphRenderer.render(): clamp texture binds to the sampler budget so pages overflowing maxAtlasPages cannot TypeError and kill rendering Verified: two-terminal shared-atlas harness (storm scenario proves the no-op and its fix; 6-seed adversarial fuzzer clean), 405 unit tests in pane-manager/atlas-recovery suites, terminal-rendering golden e2e.
Aligns status bar, tooltip, popover mocks, and mobile usage bars with the Claude/Codex harness convention (consumption meters) so a fresh account reads empty/green and a depleted one reads full/red, instead of the inverted "left" framing that misread as "full = exhausted".
…#8056) Co-authored-by: Orca <help@stably.ai>
#8174) launch-agent-in-new-tab.ts crossed the 300-line oxlint max-lines limit (303 counted lines) after #5510 and #7944 both grew it; verify only runs on PRs, so the over-limit state landed on main via a merge race and now fails lint for every open PR. Move the web-runtime host launch branch (stale-local-tab pruning plus createWebRuntimeSessionTerminal call) into launch-agent-web-host-tab.ts. No behavior change; the i18n key is kept so locale catalogs are untouched. Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
PR #7423 resized the working spinner ring from the dot size to the icon size (sm: 6px -> 10px, md: 8px -> 12px) as a side effect of the AI Vault subagent display work. The size change was unintentional in the sidebar agent rows, so restore the original dot sizing. Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
Co-authored-by: Orca <help@stably.ai>
* fix: handle headless file download version skew - Issue: remote downloads could open the local save dialog before discovering an older headless server lacks files.readChunk. - Fix: preflight the first remote chunk before starting the local download transaction. - Coverage: add regression coverage for method_not_found and preserve cleanup for mid-transfer failures. * fix: fall back for headless downloads without chunks - Issue: older headless servers can lack files.readChunk but still expose preview-sized file reads. - Fix: fall back to files.readPreview and save the file when the preview payload is usable. - Coverage: verify preview fallback success, unsupported preview update messaging, and modern chunk cleanup. * fix: reduce remote download support probe - Issue: the chunk-support probe downloaded a full chunk before the real save flow started. - Fix: probe chunk support with a one-byte read and keep the actual download starting from offset zero. - Coverage: add a transport-failure probe test and name the remote download args type. * fix: preserve empty binary preview downloads Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com> Co-authored-by: Orca <help@stably.ai>
* Fix SSH worktree delete routing * Harden host-scoped worktree deletion Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com> Co-authored-by: Orca <help@stably.ai>
Co-authored-by: Orca <help@stably.ai>
Drop accidental mobile mock HTML and strip trailing spaces from the kill-all-sessions design note without changing prose.
…#8049) The no-ripgrep git fallback ran both ls-files passes under Promise.all with killSurvivors on first rejection, so any ignored-pass failure (timeout, kill, non-zero exit) discarded the successful primary listing and Quick Open showed an error with zero files — the all-or-nothing failure called out in #7719. Directory collapse (#7842) bounds the enumeration so timeouts are far less likely, but a single-pass failure still nuked every result. Now, in the local main process and the SSH relay alike, only a primary-pass failure is fatal: an ignored-pass failure logs a warning and the listing resolves with the primary results plus any ignored entries streamed before the failure. Cancellation semantics are unchanged — an aborted scan still rejects via the primary pass or the expansion's cancellation check. Fixes #7719 Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
…l + PTY flow control (integration branch) (#7214) * Skip legacy hidden skip grammar assertions * Fix hidden TUI snapshot test setup * Fix sleep wake history test contract * Fix hidden delivery startup gate helper * Fix hidden Latin skip branch predicate * Fix hidden synchronized split-boundary replay * Stabilize remote runtime mixed subscription test * Keep hidden startup query parser active during window * Stabilize raw emoji golden restore width * Stabilize raw emoji golden fixture completion * Keep terminals responsive under agent output load * Add frozen-terminal repro harness and silent-drop regression tests Investigation harness for the frozen-terminal reports (Discord #performance, issue #2836): pane shows content, shell alive, daemon output.log flat while typing. - e2e: renderer crash -> auto-reload recovery and three restart/restore shapes (live daemon, SIGSTOP-wedged daemon, daemon killed between launches), each probing input at both drop layers. Post-crash phases drive the renderer from the main process because a crashed target severs Playwright's CDP session even though the app recovers. - e2e helpers: layer-discriminating probes (direct pty.write vs transport input, plus pty:listSessions ownership-rebuild revival). - unit repro: vendored xterm 6.1.0-beta.287 WriteBuffer permanently wedges when a sync throw escapes a write-completion callback or a custom parser handler (xterm-write-buffer-stall.repro.test.ts). - unit repros for both silent input-drop layers: main drops writes for a live PTY once ptyOwnership loses the id (revived by listSessions), and the renderer transport stays unbound after a failed connect. - pty.test.ts: unregister every leaked SSH provider id in afterEach so module-level provider state cannot leak across tests. Co-authored-by: Orca <help@stably.ai> * Harden xterm write pipeline against sync-throw wedge that freezes panes A synchronous exception escaping xterm's WriteBuffer loop permanently wedges that terminal: _innerWrite has no try/catch around the parse action or the write-completion callback, the tail re-schedule never runs, and write() only re-arms on an empty buffer. The pane stops rendering and, if a replay was in flight, the replay guard latches and pty-connection's onData silently eats every keystroke — matching the field reports (Discord #performance, issue #2836: content visible, shell alive, daemon output.log flat). Both vectors verified against vendored xterm 6.1.0-beta.287 in xterm-write-buffer-stall.repro.test.ts. Three layers of defense: - Guard every write-completion callback Orca hands xterm at the two choke points (writeForegroundTerminalChunk, writeBackgroundTerminalChunk), with settle and onParsed guarded separately so a WebGL/renderer failure during viewport settle cannot starve the replay-guard release. - Guard all throwing-capable custom parser handlers (DA1, OSC 10/11, CSI ?h/?l mode reports, OSC 52 clipboard, OSC 7 cwd), degrading a throw to "not handled" — same escape class as terminal-link-provider-guard.ts. - Replay-guard watchdog: each engagement releases exactly once, from xterm's completion or a 10s watchdog, so a lost completion (wedged pipeline, disposed-terminal race) cannot latch the guard on a live pane; replayIntoTerminalAsync resolves on either path so restore chains cannot hang. Force-releases record a crash breadcrumb. All guard trips record rate-capped crash breadcrumbs, so the next field occurrence names the throwing stack instead of failing silently. Co-authored-by: Orca <help@stably.ai> * Cap unbounded terminal output buffers in main and the foreground queue Field evidence (Discord #performance / #2836): renderer memory climbs to ~1.5 GB and terminals freeze; a force reload does not help until memory recovers. Two unbounded buffers matched that shape: - Main-process pendingData grew by string concatenation without bound while the renderer could not receive (frozen, starved, mid-reload) — main-heap bloat a renderer reload cannot clear. Now capped at 2 MB per PTY: past the cap the buffered bytes are dropped and the entry stays O(1) until the renderer ACKs again, then a droppedOutput sentinel is delivered and the pane repaints from the authoritative main-owned buffer snapshot (existing hidden-output restore path) instead of continuing a stream with a silent gap. - The renderer output scheduler capped only hidden-pane backlogs; the foreground path could queue a visible pane's flood without bound when the drain could not keep up. The 2 MB cap now applies to every foreground enqueue branch too, with a foreground-specific skip notice. Verified: new main-side cap test (starve → flood → sentinel → normal flow resumes), renderer sentinel-to-snapshot-restore test, two foreground scheduler cap tests; full pty/terminal-pane/pane-manager suites (1981 tests) and typecheck pass. Co-authored-by: Orca <help@stably.ai> * Make replay-guard stall release probe-certified instead of time-based The previous stall watchdog blindly released the input guard after 10s. If a replay were genuinely still parsing on a starved machine, that early release could leak xterm's auto-replies into the shell — and into agent TUIs, where a leaked ESC reads as the user pressing Escape. Replace the blind release with a probe: when a completion looks overdue, enqueue an empty write behind the replay. xterm parses writes in order, so every outcome is provably safe: - probe parses after the replay completion ran: normal release already happened; probe is a no-op. - probe parses but the replay completion never ran: all replay bytes have parsed, no further auto-replies can exist — the completion was genuinely lost. Release + breadcrumb. - probe never parses (bounded wait): the pipeline is wedged, and a dead parser can never emit auto-replies, so releasing cannot leak input. Release + breadcrumb naming the pane as needing recovery. While the probe is pending — a slow-but-alive replay — the guard now HOLDS instead of releasing early; that case is pinned by a regression test. Co-authored-by: Orca <help@stably.ai> * Scale output backlog caps with the scrollback setting and breadcrumb drops The 2 MB pending-output caps were flat, which risked dropping lines a 50k-row scrollback user would have retained. Both caps (main pendingData and the renderer output queue) now derive from one shared policy: max(2 MB, scrollbackRows x 120 chars) — 2 MB at the 5k default, 6 MB at the 50k max. The main side reads the setting live via getSettings; the renderer scheduler is configured where the terminal lifecycle already reads the scrollback setting. Every drop now records a rate-limited crash breadcrumb with dropped and cap sizes (terminal_output_backlog_dropped in the renderer, terminal_pending_output_dropped in main — no pty ids, session ids can embed workspace paths). Field drop frequency and size decide whether the cap constants need raising, replacing theory with data (#2836, #7017). Backlog skip notices are now cap-agnostic since the limit varies. Co-authored-by: Orca <help@stably.ai> * Extract breadcrumb recording into a collection-safe leaf module Playwright loads spec imports at collection time, and e2e specs import terminal-module constants (e.g. terminal-attention.spec.ts pulls POST_REPLAY_MODE_RESET from layout-serialization, whose chain reaches replay-guard). The breadcrumb import added to the terminal modules made that chain reach crash-diagnostics.ts, whose top-level import.meta.hot and webview-registry import crash Playwright's transform ("ReferenceError: exports is not defined in ES module scope") — every e2e shard failed at collection before running a single test. Move recordRendererCrashBreadcrumb into crash-breadcrumb-recorder.ts (type-only imports, no import.meta) and point the terminal modules and their test mocks at it; crash-diagnostics re-exports for existing callers. Full e2e suite collects again (262 tests / 94 files); unit suites, typecheck, lint green. No runtime behavior change. Co-authored-by: Orca <help@stably.ai> * Add cross-terminal pipeline benchmark (DSR-fenced throughput + latency probe) Run inside any terminal (Orca pane, iTerm2, Ghostty, Terminal.app, VS Code) to measure its full byte path. DSR round-trip latency at idle and under a paced agent-TUI load, plus fenced throughput over four deterministic fixtures. The DSR fence forces 'all bytes parsed' before the clock stops so xterm.js-class ingest queues can't flatter the result. First piece of the terminal performance initiative's measurement rig. Co-authored-by: Orca <help@stably.ai> * Add terminal performance initiative plan Working plan for the orca-performance branch: verified architecture findings, workstreams (baselines, #7153 validation, term-speed-2 revival with merge-scout numbers, stall fixes, flow control, rig extensions, utilityProcess router, telemetry), benchmark protocol, sequencing, and baseline-relative success criteria. Co-authored-by: Orca <help@stably.ai> * Add cross-terminal baseline results (Orca 1.4.91 prod vs Terminal.app vs Ghostty) Headline: Orca DSR latency under 1MB/s agent-TUI load is p50 134ms / p99 292ms vs 0.45ms (Terminal.app) and 0.21ms (Ghostty). Idle latency is fine (0.69ms p50) — the problem is queueing under load, not the pipeline hop. agent-tui fenced throughput: Orca 2.0 MB/s vs Terminal.app 37 MB/s, Ghostty 78 MB/s. Co-authored-by: Orca <help@stably.ai> * Add pipeline-loss decomposition benches (headless xterm + daemon ingest) Both isolate layers of the 51x agent-tui gap found in baseline-jul02: bare @xterm/headless parses agent-tui at 103 MB/s and daemon Session ingest (emulator + pending-output recording + fanout) at 103 MB/s — on the byte stream the full Orca pipeline delivers at 2.0 MB/s. Parser and daemon are exonerated; the loss is in main per-chunk processing, delivery/ACK pacing, or renderer layers above xterm. Co-authored-by: Orca <help@stably.ai> * Record baseline + decomposition findings in initiative plan Co-authored-by: Orca <help@stably.ai> * Add dev-build orca-performance bench result (confounded: dev mode, 282-col window, 3MB fixtures) DSR under load p50 161ms — the #7139/#7150 branch does not move the under-load latency class. Expected in hindsight: DSR replies are ordered within the output stream, so the metric measures output-queue depth; cooperative drain paces input responsiveness but cannot reorder the queue. Shrinking the queue itself (producer flow control, task 6) and raising agent-tui throughput (task 9) are the levers for this number. Co-authored-by: Orca <help@stably.ai> * Record dev-build #7153 check in findings log Co-authored-by: Orca <help@stably.ai> * Parse-clock high-priority terminal drains instead of fixed-nap dripping Attribution (task #9): the drain loop wrote at most 2x16KB then slept 4/16ms regardless of parse speed — an isolation bench (new pane-terminal-output-scheduler-throughput.bench.test.ts) measures that drip at 1.9 MB/s background / 27 MB/s foreground against xterm's ~103 MB/s parse rate, matching the baseline-jul02 end-to-end numbers (agent-tui 2.0 MB/s in prod 1.4.91). Fix: high-priority (visible-pane) drains now re-arm on xterm's parse-completion callback and carry 8 writes per tick; the isolation ceiling rises 27 -> 117.6 MB/s (parse-limited). Background cadence is deliberately unchanged (2 MB/s drip protects the focused pane; hidden delivery is term-speed-2's job). DRAIN_TIME_BUDGET_MS still bounds per-tick work, preserving #7139's cooperative-drain intent. Validation: 621 scheduler/guard/pty tests green, typecheck clean. Co-authored-by: Orca <help@stably.ai> * Record task #9 attribution + parse-clock fix in findings log Co-authored-by: Orca <help@stably.ai> * Findings: 51x loss attributed to O(tail) retained-tail redraw path in main onPtyData Co-authored-by: Orca <help@stably.ai> * Window the retained-tail redraw path to the cursor's reach Attribution (findings log 2026-07-03): main's onPtyData consumed ~93% of the event loop under an agent-TUI flood, and the dominant term was appendNormalizedToMultilineTailBuffer + finalizeRetainedTerminalRows materializing ~2x tail-length row objects plus a per-row trailing-space regex on every chunk — 0.888ms/chunk at the 2,000-line cap, on every Claude-Code-shaped frame (cursor-up + erase-below). The multiline algorithm now runs on a suffix window sized by the chunk's maximum upward cursor excursion (plus the inherited redraw cursor and a safety margin); the untouched prefix is shared by reference with a cheap last-char trailing-space check to match the reference trim. Pathological full-height cursor-ups fall back to the unwindowed implementation, which is kept verbatim and exported as the reference for the 500-case differential fuzz (retained-tail-redraw-window.equivalence.test.ts). Micro-bench at a full 2,000-line tail: 0.888 -> 0.073 ms/chunk (12x). 1,415 runtime tests green, typecheck clean. Co-authored-by: Orca <help@stably.ai> * Add dev bench results: parse-clock and windowed-tail fixes Co-authored-by: Orca <help@stably.ai> * Record windowed-tail partial win + next-cycle recipe in findings log Co-authored-by: Orca <help@stably.ai> * Findings: remaining whale is the per-chunk blocked-reason check (~85% of onPtyData post-fix) Co-authored-by: Orca <help@stably.ai> * Throttle the terminal wait-blocked check off the PTY hot path Post-windowed-tail attribution (findings log 2026-07-03): the blocked- reason complex — two full-tail buildTerminalWaitText builds plus toLowerCase and multi-pattern scans per chunk, existing only to stamp waitBlockedAt — consumed ~85% of onPtyData's remaining cost (~700-790ms/s under an agent-TUI flood). The check now runs at a 50ms cadence over coalesced chunks (PTY chunk boundaries are arbitrary, so coalescing preserves semantics), with a trailing-edge timer so burst-final state is always evaluated, and an immediate bypass when the incoming chunk (plus a 31-char split carry) contains a prompt keyword — so actionable-prompt stamping stays per-chunk-immediate while keyword-free flood frames skip the complex entirely. Previous wait text is cached per pty instead of rebuilt, and state is cleared at both pty teardown sites. 1,415 runtime tests green (including the cross-chunk prompt test, which exercises the keyword bypass), typecheck and lint clean. Co-authored-by: Orca <help@stably.ai> * Findings + results: three stacked fixes unlock the pipeline (agent-tui 16x, DSR-load p50 161->18.8ms in dev) Co-authored-by: Orca <help@stably.ai> * Add producer flow-control design to initiative plan Co-authored-by: Orca <help@stably.ai> * Findings: revival branch green but perf-gated — daemon Session ingest regressed 103->40-48 MB/s (chain emulator restructure); merge blocked until blockedfix parity Co-authored-by: Orca <help@stably.ai> * Pre-filter daemon OSC/mouse scanners for introducer-free chunks Skips the scan-tail copy and full-chunk walks when a chunk cannot contain an OSC or private-mode sequence (single native includes() checks), with split-sequence correctness preserved via explicit tail retention. Strictly positive micro-optimization on the daemon per-chunk path; 641 daemon tests green (1 pre-existing WSL failure unrelated). Co-authored-by: Orca <help@stably.ai> * Retract confounded daemon conviction; mandate load-controlled A/B protocol for the revival merge gate Co-authored-by: Orca <help@stably.ai> * Record A/B gate pass in findings log; add A/B result JSONs Co-authored-by: Orca <help@stably.ai> * Add producer-side PTY flow control (watermarks + protocol v19) Main now pauses the actual PTY when a pane's renderer-pending backlog crosses the 256KB high watermark and resumes once it drains below the 32KB low watermark (wide hysteresis band so a draining queue cannot flap pause/resume per flush slice). node-pty pause() stops the pty fd read, so the kernel/ConPTY buffer fills and a flooding shell blocks on write — flood-induced buffered lag becomes shell blocking instead of unbounded main-process buffering (terminal-performance-initiative §5). Transport: new fire-and-forget pausePty/resumePty daemon notifications (protocol v19; 18 added to PREVIOUS_DAEMON_PROTOCOL_VERSIONS), routed DaemonServer -> TerminalHost -> Session -> subprocess pause()/resume(). LocalPtyProvider pauses node-pty directly. Router/degraded providers forward; IPtyProvider gains optional pauseProducer/resumeProducer. Safety invariants: - Lost-resume failsafe: daemon Session auto-resumes 5s after a pause with no matching resume; main re-asserts the pause at most once per 5s while still above the high watermark, so a lost resume can never wedge a shell and a sustained flood stays throttled. - Resume on every teardown path: Session kill/exit/dispose/detach; main releases on pty exit and on window-destroyed bookkeeping wipes; the adapter owes paused sessions a resumePty on the next connect after a socket drop. - Providers without support (SSH relay, legacy protocol <= v18) no-op silently, and the scrollback-scaled pending-output cap still bounds main memory when pause is unavailable. - Kill switch: PRODUCER_FLOW_CONTROL_ENABLED in ipc/pty.ts flips the whole mechanism off in one line. daemon-errors.ts is split out of types.ts to stay under the max-lines cap. Tests: watermark transitions/hysteresis/re-assert (controller unit), lost-resume failsafe + resume-on-kill/exit/dispose/detach (session), notification routing + v18 gating + reconnect owed-resume (adapter), direct pause/resume (local provider), and a flood test asserting pause fires once, pending stays bounded at HIGH + one chunk, and resume fires once after drain (ipc/pty). Co-authored-by: Orca <help@stably.ai> * Findings: flow control merged; definition-of-done accounting; prod verification re-scoped to packaged RC Co-authored-by: Orca <help@stably.ai> * Fix stray brace from revival merge in long-table-scroll-restore e2e spec (broke e2e transform in CI) Co-authored-by: Orca <help@stably.ai> * Prod verdict: v1.4.121-rc.0 bench — DSR-load p50 134->18.6ms (7.2x), agent-tui 2.0->11.2 MB/s, idle at Terminal.app parity; pipeline now cadence-bound Co-authored-by: Orca <help@stably.ai> * Recover terminal output delivery after system sleep Root cause: main gates every pty:data send on a global + per-PTY in-flight counter that only renderer ACKs decrement. If ACKs are lost across a system suspend, the counters pin at the cap and every PTY — old and newly created — is silently gated forever while output piles up in pendingData. A focus-preserving display wake also fires no renderer focus/visibilitychange events, so terminal wake recovery (and the WebGL context-loss latch clear) never runs. Only a renderer reload recovered. Three fixes: - ACK-stall watchdog (src/main/ipc/pty.ts): if sends stay gate-blocked for 10s with zero ACK progress while the renderer webContents is alive, warn once, reset the in-flight delivery counters, and flush held pendingData. Armed lazily on the first gate-blocked send and disarmed by every ACK, so it can never fire under healthy heavy load. - Renderer lifecycle reset now also zeroes the in-flight counters — a reload/navigation destroys the renderer dispatcher, so outstanding ACKs can never arrive and stale counters would gate the new renderer. - System-resume wake IPC: main relays powerMonitor 'resume' as system:resumed to live windows (plus forceRepaint); preload exposes ui.onSystemResumed; the terminal wake-recovery hook runs the same recovery path as window focus/visibilitychange. Co-authored-by: Orca <help@stably.ai> * VS Code head-to-head: Orca beats/ties 5 of 6 metrics (16x idle, 5x styles-stress, better p99); load p50 gap attributed to ACK window + timer-clamped drain cadence Co-authored-by: Orca <help@stably.ai> * Schedule zero-delay terminal drains via MessageChannel Chromium clamps nested setTimeout(0) to ~4ms, stacking dead gaps onto every parse-clocked drain tick; the explicit 4ms high-priority re-arm interval added more. A posted message is still a macrotask — input and paint are serviced between posts — so cooperative yielding survives without the clamp. Generation-tokened cancellation; vitest keeps the timer path (fake timers can't advance channel posts) plus a real-timer smoke test for the channel path. Standing-queue target: VS Code's ~7ms class (measured us 18.6ms, them 7.18ms, same rig). Co-authored-by: Orca <help@stably.ai> * Cut daemon and main PTY batch windows 8ms -> 2ms At 9% pipeline utilization the DSR-under-load latency is fixed batching windows, not queue depth (proved by the MessageChannel drain lever moving nothing). Both hops charged an expected half-window per chunk; 2ms keeps burst coalescing at negligible IPC overhead (~500 msgs/s worst case vs MB/s payloads). Co-authored-by: Orca <help@stably.ai> * Findings + tests: batch windows were the DSR-load gap (19->8.0ms dev); timing tests updated to 2ms windows Co-authored-by: Orca <help@stably.ai> * Fix PR CI and guard resume relay during shutdown Co-authored-by: Orca <help@stably.ai> * Chain e2e specs 6/6 green — gate x drain validation debt paid Co-authored-by: Orca <help@stably.ai> * Replace ack-stall watchdog with cumulative ACKs + solicited delivery resync Design review: the 10s blind-reset watchdog decided correctness from a wall-clock threshold. Rework piece 1 into a deterministic two-part design (pieces 2 and 3 — lifecycle-reset counter zeroing and powerMonitor wake IPC — are unchanged): - Cumulative ACKs (TCP-style): the renderer dispatcher now tracks a monotonic per-pty total of processed chars (terminal-pty-ack-gate) and sends it on every ACK alongside the legacy per-chunk delta. Main keeps per-pty sentChars/ackedChars and max-merges received totals — idempotent and reorder-tolerant, so a lost ACK self-heals when any later ACK arrives instead of becoming permanent in-flight debt. Provider (SSH/daemon) backpressure is credited only the derived delta, clamped, never negative. Main tolerates both payload shapes keyed by field presence (dev hot-reload can mix renderer/main versions); totals reset on pty exit and renderer lifecycle reset on both sides. - Solicited resync (replaces the blind reset): when new pty data arrives while that pty's delivery is fully gated and no probe is outstanding, main sends pty:requestDeliveryResync; the renderer replies with its cumulative totals and main reconciles via max-merge, then flushes held pendingData. Event-triggered, verified-state recovery — no wall-clock threshold decides correctness. The only timer is a 5s request/response hygiene timeout that clears the outstanding flag and logs one diagnostic warn per silent streak; it never mutates counters (a renderer that cannot answer has dead IPC — reload is the only cure). The 10s corrective watchdog is deleted. Co-authored-by: Orca <help@stably.ai> * Starting point: prior agent's garble differential fuzz harness Three files recovered (were untracked) from a prior agent killed by API outages, plus a trivial curly-brace lint fix in the op dispatcher so the pre-commit hook passes: - src/shared/agent-tui-ansi-fuzz-stream.ts (seeded agent-TUI byte-stream gen) - src/shared/terminal-restore-parity-fixture.ts (renderer-parity fixture) - src/main/daemon/headless-emulator-fidelity.fuzz.test.ts (suite 1: differential HeadlessEmulator vs @xterm/headless reference on identical bytes) Co-authored-by: Orca <help@stably.ai> * Suite 1 findings: two new serialize round-trip bugs (B bold-loss, C cursor) Scanned seeds 1..2000. Beyond the pre-documented serialize wrap-null-cell bug (A, 27 seeds, tolerated), the fuzz surfaced two NEW real @xterm/addon-serialize 0.15.0-beta.287 round-trip defects, both of which garble a revealed hidden pane: - Bug B (seeds 435, 770, 1321): serializing a dim cell followed by a bold-only cell emits \x1b[1;22m; SGR 22 clears bold too, so restored bold is lost. Minimal repro: '\x1b[2mA\x1b[22m\x1b[1mB' -> restored 'B' loses bold. - Bug C (seeds 454, 1696): a final content row filled to the right margin leaves xterm wrap-pending; the serializer's relative cursor restore lands one column short. Minimal repro: '0123456789\x1b[3;5H' at cols=10 -> cursor x=3 not x=4. Both isolated to pure serializer replay (no Orca preamble), confirming upstream. Parity fixture verified faithful to the renderer pane's buffer options. Each is pinned as a standalone it.skip repro; full evidence + classification in notes/garble-fuzz-divergences.md. Seed 113 (handoff's DECSC/DECRC case) does not diverge on the current harness. No production code changed. Co-authored-by: Orca <help@stably.ai> * Add perf prerelease update check modifier Co-authored-by: Orca <help@stably.ai> * Suite 2: hidden-reveal seq-reconciliation fuzz + two new snapshot bugs (D, E) Property-tests the reveal seq-reconciliation byte-stitch (getChunkDataAfterSnapshot / reconcileChunkAgainstRestoredSnapshot in pty-connection.ts), mirrored exactly: N=200 seeded hide/reveal scenarios with a rich agent-TUI hidden prefix snapshot and an append-only racing tail, chunked with seq/rawLength meta, seq-domain restarts, unmetered chunks and droppedOutput markers. Asserts snapshot-at-S + reconciled tail == snapshot-of-everything (seq-neutral) and == always-visible (end-to-end). Runtime ~5s at 200; FUZZ_ITERATIONS override documented. Two NEW real snapshot-limitation garbles found while building it, both distinct from suite 1's serialize bugs and pinned as standalone it.skip repros: - Bug D: the DECSC saved-cursor register is not serialized. A hidden TUI that saves the cursor (ESC 7 / CSI s) and restores it on reveal (ESC 8 / CSI u) lands the restore at home. Repro: 'AB\x1b7\x1b[4;10HCD' + '\x1b8X' -> 'XB' vs 'ABX'. - Bug E: a snapshot taken mid-escape-sequence (a PTY read split an escape) drops the partial sequence (it's parser state, not buffer), so the tail's continuation renders literal. Repro: 'AB\x1b[3' + 'mCD' -> 'ABmCD' vs 'ABCD'. Fired on ~24% of the corpus (tolerated + counted via prefixEndsMidSequence). The append-only-tail design isolates seq reconciliation from these and the Bug C cursor cascade. Full evidence + fix directions in notes. No production changes. Co-authored-by: Orca <help@stably.ai> * Suite 3: 25-cycle park/reveal drift e2e test Extends terminal-hidden-view-parking.spec.ts with a deterministic 25-cycle park->reveal test on a static rich alt-screen TUI frame (box drawing, SGR colors, wide CJK/emoji). Baselines against the frame after the first snapshot restore (so both sides pass through identical machinery — the alt-screen restore correctly drops normal-buffer scrollback, which is contract not garble), then asserts every subsequent reveal reproduces it byte-for-byte with no accumulated drift and no hidden-skip banner. Exercises the real renderer teardown + HeadlessEmulator snapshot restore + PTY reattach path the fuzz suites model in isolation. Passes in ~29s (electron-headless, workers=1). Co-authored-by: Orca <help@stably.ai> * Fix two serialize round-trip bugs garbling hidden-terminal snapshot restore BUG B (addon patch): @xterm/addon-serialize's SGR diff emitted bold/dim set params before the shared intensity reset 22, so "1;22" wiped a freshly set bold and a bare "22" dropped a still-set bold/dim. Patched via pnpm patchedDependencies (config/patches) to diff bold+dim as one intensity group with the clearing 22 emitted first. Other flag pairs (4/24, 3/23, 7/27, ...) have dedicated resets and were verified unaffected. BUG C (Orca-side hardening): the addon restores the cursor with relative moves computed from where it assumes replay leaves the cursor; a final row filled exactly to the right margin leaves replay wrap-pending and the restore lands one column short. New shared serializeWithAbsoluteCursor appends an absolute CUP from the source terminal's authoritative cursor at every restore/replay serialize site (daemon/runtime HeadlessEmulator.getSnapshot, renderer mobile snapshot serializer, shutdown layout capture). It skips empty snapshots and wrap-pending sources so it never changes already-correct behavior. Round-trip repros + non-regression coverage in src/main/daemon/terminal-snapshot-serialize-roundtrip.test.ts (verified failing with the fixes stashed). buildRehydrateSequences extracted to its own module to keep headless-emulator.ts under the max-lines budget. Co-authored-by: Orca <help@stably.ai> * Gates: tolerate+count Bugs B/C in deep mode; drop inverse from reconciliation tail - Fidelity suite: add snapshotHasSelfCancellingBoldReset (Bug B) and isMarginWrapPendingCursorOffByOne (Bug C) predicates so the corpus tolerates + counts them like Bug A. FUZZ_ITERATIONS=2000 is now green (~113s) and fails only on genuinely new divergences; each tolerance keeps its <50% degeneracy guard. Default 300 unchanged (~17s). - Reconciliation suite: drop SGR 7 (inverse) from the append-only tail. Inverse marks trailing blanks with an inverse-fg the serializer round-trips slightly differently by capture depth — a Bug-B-class serialize nuance, not seq reconciliation. FUZZ_ITERATIONS=1000 is now green; default 200 unchanged. - Notes updated: every bug class is both pinned (skipped repro) and tolerated in its corpus; combined default runtime ~19s. Regex uses String.fromCharCode(27) to stay oxlint no-control-regex clean. Co-authored-by: Orca <help@stably.ai> * Keep RC update checks off perf prereleases Co-authored-by: Orca <help@stably.ai> * Fix snapshot DECSC register loss (Bug D) and mid-escape boundary drop (Bug E) Bug D: the serialized screen cannot carry the VT100 DECSC saved-cursor register, so a hidden ESC 7 followed by a post-reveal ESC 8 restored to home and clobbered live cells. The snapshot epilogue now re-saves at the source's saved position before the final absolute CUP (readSavedCursorRegister + serializeWithAbsoluteCursor; the active buffer's own register, so alt screens carry theirs). Position-only by design; never-saved terminals are left untouched. Bug E: a PTY read ending mid-escape leaves the sequence in the emulator's parser, so serialize dropped it and the racing tail's continuation bytes rendered literally after reveal (~24% of the fuzz corpus). The emulator now tracks the unparsed trailing partial at ingest (terminal-partial-escape-tail.ts, committed post-parse like the mouse mirror) and ships it as TerminalSnapshot.pendingEscapeTailAnsi. applyMainBufferSnapshot writes it LAST, after POST_REPLAY reset — any later ESC would abort the dangling sequence. Seq accounting is unchanged: the tail is a suffix of bytes the snapshot seq already counts, so reconcile slicing needs no adjustment. Fuzz suites: unskip the Bug B/C repros (fixed on this branch) and the new D/E repros; remove the B/C/E tolerance predicates so regressions fail loudly. Only Bug A (upstream wrap null-cell) stays tolerated + counted. Green at FUZZ_ITERATIONS=2000 (fidelity) and 1000 (reconciliation). Co-authored-by: Orca <help@stably.ai> * Count suffixed RC tags (rc.N.perf) in the shared rc counter — second suffixed cut collided with the first Co-authored-by: Orca <help@stably.ai> * Classify suffixed rc tags (rc.N.perf) as rc telemetry identity in release builds The build-identity guard only knew vX.Y.Z and vX.Y.Z-rc.N, so suffixed perf RCs cut fine but every platform build refused the tag and the releases published empty. Co-authored-by: Orca <help@stably.ai> * Cut the hidden-restore flood feedback loop (A) + query carve-out on drops (B) (A) Under a foreground flood, the hidden-output-restore loop re-fetched snapshots endlessly: each synchronous applyMainBufferSnapshot starved ACK processing, main pinned at the in-flight cap, dropped at the pending cap, and every droppedOutput/modelRestoreNeeded marker re-armed another restore until the flood ended (rc.7.perf DSR timeouts). - Restore loop: a foreground live-chunk queue overflow now abandons the restore immediately (the stream is outrunning snapshot fetch+replay), with a 3-iteration hard cap + lifecycle warn as backstop. - Re-arm gate: drop markers/sentinels and reconcile seq-gaps on a visible pane during its own in-flight/just-abandoned restore no longer re-arm; live bytes write through and ONE deferred repaint (2s after the last backpressure signal) heals the gap. Hidden-pane gate semantics are unchanged. - Query salvage: discarding queued restore bytes (overflow/refetch) now extracts DSR/CPR/DA/OSC-color queries and replays them to xterm so replies still flow. (B) Main-side: dropOversizedPendingPtyData carves reply-eliciting query sequences out of the dropped buffer (and out of post-drop latched data, bounded) and ships them on the droppedOutput sentinel, so DSR probes survive bulk drops. Query scanning moved to src/shared/terminal-reply-query-extraction.ts, shared verbatim with the renderer's hidden-startup query extraction. Co-authored-by: Orca <help@stably.ai> * ACK terminal output at parse-drain, not dispatcher enqueue (C) The renderer credited main's per-PTY in-flight window the moment a pty:data chunk entered the dispatcher, so the 512KB window meant "bytes received", never "bytes parsed". Under flood the renderer write queue grew unbounded behind instant ACKs; main saw no backpressure, crossed the pending cap, and bulk-dropped output (rc.7.perf DSR timeouts). Crediting is now parse-deferred: each delivery carries a fire-once credit (deliverPtyDataWithDeferredAck); the pane's first scheduler write claims it (writeTerminalOutput.ackCredit) and the output scheduler fires it when the bytes are consumed — after terminal.write in the parse-clocked drain, or on ANY discard path (backlog cap replacement, discardTerminalOutput, disposed-terminal drops, flush recovery). Deliveries that never reach the scheduler (reconcile drops, restore queueing, pre-mount eager buffer) settle at handler return, so the invariant holds: every delivered chunk credits exactly once, parsed or discarded. E2E ack-gate hold/release and delivery-resync semantics are unchanged (all crediting still routes through ackPtyData). Main-side equilibrium: with ACKs at parse cadence, in-flight becomes true backpressure — pendingData stays near the 256KB producer-pause watermark, far under the >=2MB drop cap, so bulk floods block the shell (node-pty pause) instead of dropping. Co-authored-by: Orca <help@stably.ai> * Synthesize salvaged query replies directly instead of replaying into xterm The 10MB dev bench proved the write-back salvage insufficient: a pending-cap drop always triggers a snapshot restore, whose replay guard swallows xterm auto-replies and whose discardTerminalOutput races away still-queued query writes — the salvaged DSR died both ways and the fence still timed out. Salvage now answers directly on the input path (immune to both): CPR (CSI 6n) from the live buffer via transport.sendInput, DA1 with the renderer's canned response, OSC color probes via the existing direct responder. Rare queries (DECRQM, DA2) keep the best-effort xterm replay. Co-authored-by: Orca <help@stably.ai> * Untrack branch-added bench result JSONs (20 files); keep numbers in the findings log Files stay on disk; main's 7 pre-existing results are untouched. Co-authored-by: Orca <help@stably.ai> * Branch guide: document merge-not-rebase sync strategy and conflict pattern Co-authored-by: Orca <help@stably.ai> * Merge origin/main (#7316 tab-strip click-vs-drag fix); adapt #7290 recovery-reload tests to this branch's dual did-finish-load listeners The three tests grabbed the FIRST did-finish-load listener; on this branch the renderer delivery-gate reset registers before the orphan sweep, so the sweep tests exercised the wrong handler (one failing, two vacuously green). They now fire all listeners like a real reload. Co-authored-by: Orca <help@stably.ai> * Fix branch CI lint: split pane-interaction functions out of artificial-opencode-terminal-load.spec (815>800 lines), modernize perf-html-report script No max-lines disable per repo rules; extracted to artificial-opencode-pane-interactions.ts. toReversed() and import.meta.filename replace reverse()/fileURLToPath. Co-authored-by: Orca <help@stably.ai> * Fix Windows update-relaunch killing the live terminal daemon On a Windows update relaunch the daemon can be wedged past every RPC budget (final checkpoint flush + installer/AV disk pressure), so the 3s health check AND the 5s session-list hello both time out while sessions are still alive - and the launcher failed closed, killing the daemon and every terminal session it owned. - Adopt an unresponsive daemon whose pipe still accepts a raw connection; a new rejected health state keeps replacing daemons that answered and refused the handshake (never adoptable). - Give Windows pid files a real startedAtMs (daemon self-reports it in the ready IPC message) and verify it via CIM CreationDate piggybacked on the existing command-line query, so the pid-recycling guard is no longer inert on win32. - Only delete legacy daemon pid/token files when the pid-file process is provably dead; deleting a live daemon''s token made its sessions permanently unadoptable after a protocol bump. - Capture agent resume records every 60s in the renderer (skipping unchanged records) so hard kills still leave a fresh resume record. * Heal blank terminals when main→renderer push delivery dies (renderer-pull delivery watchdog) Field evidence (v1.4.121-rc.0 debug snapshot, 2026-07-06): a wedged window held 530,115 un-ACKed in-flight chars — one PTY pinned at the 512KiB per-PTY high water plus a fresh terminal's 245-char prompt that was sent and never consumed — while the user ran the snapshot over invoke from that same window. Main→renderer push delivery (pty:data and every sibling channel) was dead; renderer→main→renderer invoke was alive. Upstream precedent for one-directional IPC death: electron#37067 (suspected Mojo pipe disconnect, stalled as need-info). Every terminal goes blank, new terminals are born blank, and only a renderer reload recovered. The existing recovery layers cover the OTHER variants of this bug family and structurally cannot reach this one: - The xterm write-pipeline sync-throw guards, output-buffer caps, and probe-certified replay-guard release (#7150 family) run only after bytes arrive in the renderer — here they never do. (The pending cap did work as designed in the field: ~2.1MB pendingDroppedChars, bounded main heap.) - Cumulative ACKs self-heal lost ACK messages and the solicited delivery resync reconciles verified totals (4647df86a; #7260 on main) — but the resync probe, the powerMonitor wake relay, and the droppedOutput restore markers all ride main→renderer push, the direction that is dead. The probe's unanswered path deliberately only logs. This adds the missing lane, renderer-initiated and ridden entirely over invoke — the direction the field snapshot proved alive: - terminal-delivery-watchdog.ts: 15s heartbeat, free while output flows. Hot-path cost is one Map upsert per received chunk; a tick does no IPC unless the terminal plane was silent for the whole interval and a PTY still expects delivery. Two consecutive silent ticks with main reporting ACK-starved in-flight confirm the wedge; heals are one-shot per 60s cooldown so a persisting wedge cannot repaint-storm. - pty:reportRendererDeliveryState (invoke): always max-merges the renderer's cumulative processed totals (a free extra repair lane for the lost-ACK variant); with heal:true — and only after main has itself seen ≥10s of ACK silence — writes off bytes the renderer provably never received (received ≤ acked < sent; a received-but-unparsed backpressure window is never written off), drops that PTY's pendingData (snapshot covers everything ≤ markerSeq, hidden-drop parity), credits provider flow control, and returns restore markers in the reply. - The renderer re-attaches all push listeners (cures a detached-listener variant outright; a safe no-op against a dead channel) and routes the pulled markers through the existing pty:modelRestoreNeeded machinery — panes repaint from the main-owned buffer snapshot with zero push delivery involved. - Field discrimination built in: the heal warn logs ipcRenderer.listenerCount('pty:data') (listener detached vs channel dead) with the full delivery snapshot, so the next occurrence names the root cause without asking the user to run anything in a console. Repro harness: the exposeStore-gated __terminalDeliveryWatchdog hook blackholes pty:data ahead of the dispatcher — the field failure in miniature (no receive count, no ACK credit, no dispatch). terminal-push-delivery-loss-recovery.spec.ts proves the wedged output repaints while the blackhole is still engaged and live flow resumes after release, with no reload. Unit suites pin the watchdog state machine (zero IPC under flow, two-tick confirm, cooldown), the dispatcher reattach seam, and the main-side write-off semantics. Perf: nothing added to main's send/flush path; the renderer data path gains one integer/Map update per chunk; idle cost is one ~100-byte invoke per 15s only during total terminal silence. Terminal perf e2e suite (typing latency, redraw freeze, output scheduler, hidden TUI restore, artificial opencode load) passes on this change; no watchdog activity occurs under ack-gate pressure scenarios because receive-progress gates the heartbeat. Co-authored-by: Orca <help@stably.ai> * Expose the hidden-yet-visible delivery-gate contradiction in the debug snapshot The v1.4.124-rc.2.perf blank-terminal field snapshot showed a different state than the v1.4.121 transport wedge: no delivery gating at all (ackGatedFlushSkipCount 0, in-flight 38KB, far under every cap) but TWO ptys hidden-delivery-gated with 78MB dropped as hidden. The aggregate counters cannot say whether the pane the user was staring at was one of the gated ones — the one number that separates "normal background dropping" from "main is starving a visible pane because the reveal unmark never fired". Add hiddenDeliveryGatedVisiblePtyCount / hiddenDeliveryGatedActivePtyCount (overlap of the gate's hidden set with the renderer's visible/active reports — a contradiction that must be zero) to the delivery debug snapshot, and a once-per-minute warn when hidden-gated bytes are dropped for a pty the renderer reports visible or active, with the full snapshot attached. Zero cost outside the debug read and the already-dropping path. Co-authored-by: Orca <help@stably.ai> * Unlatch the hidden-delivery gate when user input disproves a stuck document.visibilityState macOS occlusion tracking can wedge document.visibilityState at 'hidden' after display sleep and never fire another visibilitychange. The hidden- delivery gate then keeps dropping renderer-bound bytes for panes the user is looking at (field snapshot 2026-07-06, v1.4.124-rc.2.perf: 78MB dropped across 2 pane-level-visible ptys with a fully healthy transport), and every recovery path (window focus, system-resume relay, backlog recovery) re-ran syncHiddenRendererPtyDelivery only to recompute the same stale predicate — nothing could ever clear the gate. The user sees a frozen terminal; typing echo is dropped in main; only a reload recovers. Real user input while the document claims hidden is a physical contradiction: keystrokes and clicks only reach a focused, on-screen window. stale-document-visibility.ts latches that proof, runs each pane's existing visibilitychange resync (gate unhide + hidden-output snapshot restore), and hands authority back to the occlusion tracker on the next genuine visibilitychange. No timers; the failure bias is safe — a wrong latch can only restore pre-gate delivery cost, never drop bytes. Hot path unchanged: the foreground predicate still returns on the same single comparison while the document is visible. tests/e2e/terminal-stuck-occlusion-recovery.spec.ts pins the wedge (visibilityState pinned hidden -> output dropped, not painted; the hiddenDeliveryGatedVisiblePtyCount field discriminator reads >0) and the recovery (one Shift keypress repaints the missed output from the main-owned snapshot, no reload, while visibilityState still reads hidden). Negative control verified: the spec fails without this fix. Typing-latency perf gate passes; terminal-pane unit suites 366/366. Co-authored-by: Orca <help@stably.ai> * Add a one-paste terminal freeze report: __orcaTerminalFreezeReport() Every field report of the frozen-terminal family so far has needed follow-up asks (console output, main logs, second snapshots) because each capture showed one process's counters at one instant. This makes a single DevTools command sufficient: `await window.__orcaTerminalFreezeReport()` returns renderer state (document.visibilityState + the stale-visibility override, pty:data listener count, delivery-watchdog totals), main's debug snapshot extended with a per-pty delivery table (sent/acked/pending, hidden vs visible-set membership, last send/ACK ages, window focus flags, power suspend/resume ages, app version), and bounded breadcrumb rings from BOTH processes recording the transitions that matter: gate marks/unmarks, visibilitychange and stale-visibility latches, watchdog stalls and heals, restore markers, heal write-offs, and renderer lifecycle resets (so "user already reloaded" is visible in the history). Costs stay off the data path: breadcrumbs record only rare transitions into a 100-entry ring with same-kind coalescing (a flood costs one slot per second); the per-pty table is built only when the snapshot is read; the per-send bookkeeping adds one Date.now() to existing accounting writes. Pty ids are redacted to their `@@` suffix because daemon session ids embed worktree paths. The report assembles over invoke IPC — the direction proven alive in every observed wedge — and a failing invoke is captured as data instead of sinking the report. The stuck-occlusion e2e now also pins the report end-to-end: after the wedge + keystroke recovery, the report must carry the stale-visibility latch and gate transitions in the renderer ring, gate-mark/unmark in main's ring, and a populated per-pty table. Suites: pty.test.ts 258, terminal-pane 1705, shared ring 5; typing-latency perf gate passes. Co-authored-by: Orca <help@stably.ai> * perf(daemon): keep-tail thin hidden panes' stream so agent floods never bury typing (STA multi-workspace lag) Hidden panes are exempt from pendingData flow control (main gate-drops their bytes after ingestion), so N background agents ran unbounded ahead on the one shared daemon->main stream socket (measured 192MB user-space backlog) and visible-pane echo waited FIFO behind it — typing appeared seconds late whenever several agents burst on a loaded machine (8x512KB/s + 12 CPU spinners: p50 293ms fix-off; 12x1MB/s: 6.1s). Mechanism (replaces producer pacing — no reveal catch-up, ever): - Shallow socket write gate (128KB) + per-session fairness bypass bounds echo latency by construction; kernel-flush refill sentinel keeps held bulk draining at full speed (drain-only refill capped at ~8MB/s). - Backgrounded sessions' queued output is keep-tail dropped (newest 512KB kept, in-order dataGap replaces the middle); a ~2MB GLOBAL budget shrinks per-session keep-tails (floor 64KB) so a worktree switch never waits behind the aggregate. Reply-eliciting query bytes (DSR/DA/OSC probes) are salvaged from dropped spans. - Notifications are structurally lossless: the daemon runs the same shared scanners main uses (bell/OSC 133/pr-link/2031) over every byte BEFORE drop decisions and relays facts in byte order; ordered background markers hand scan authority back and forth, seeded with the emulator's partial escape tail so a sequence split across the handoff neither phantom-fires nor goes missing. Titles/agent-status stay main-side (kept-tail convergent). - Main: background = hidden AND no remote view subscriber (a live mobile/web view is never thinned); on dataGap main resets cross-chunk parse carries, drops the headless mobile mirror, and reuses the hidden-drop model-restore marker. Wire: three new stream events, tolerated within protocol v19 (old mains ignore unknown events; old daemons never see the trigger). Kill switches: ORCA_DAEMON_BACKGROUND_STREAM_DROP=0, ORCA_DAEMON_SHALLOW_SOCKET_GATE=0. A/B (pnpm bench:multi-workspace-typing): 8x512KB/s + 12 CPU workers p50 293ms/p90 647ms -> 15/21ms (= baseline); 12x1MB/s 6,146ms -> 20ms; light loads unchanged; zero missing echoes. Latin hidden-restore e2e green (probe-verified aggregate-drain root cause). New deterministic repro harness: tests/e2e/terminal-multi-workspace-typing-latency.spec.ts + CPU pressure workers. Co-authored-by: Orca <help@stably.ai> * diag(terminal): breadcrumb WebGL context-loss/atlas + wake triggers into freeze report Silent instrumentation (memory ring only, no new console lines) so the next post-wake garble report attributes itself. Adds: - shared/terminal-webgl-diagnostics.ts: lib-safe sink so pane-webgl-renderer (lib) can record without importing the components-layer ring; wired to the ring in terminal-freeze-breadcrumbs. - webgl-context-loss crumb at onContextLoss, webgl-atlas-reset crumb at the atlas registry reset — the pair that distinguishes 'atlas corrupted' from 'missed repaint'. - wake-recovery:<source> crumb (focus/visibilitychange/system-resumed) with the clearGlyphAtlases decision; source in the kind so distinct triggers don't coalesce. - per-pane WebGL state (getAllPaneRenderingDiagnostics) in the freeze report. Gates: typecheck 0 errors; terminal suites 328 files pass; oxlint clean. Co-authored-by: Orca <help@stably.ai> * fix(lint): use Number.parseInt/parseFloat in terminal-view-attributes oxlint unicorn(prefer-number-properties) flagged 24 global parseInt/parseFloat calls in the terminal-view-attributes feature (ee540f32d, perf-branch only), failing PR Checks 'verify' lint. Mechanical global→Number.* rewrite via oxlint --fix; behaviorally identical. Pre-existed the latest main merge. Co-authored-by: Orca <help@stably.ai> * fix(test): update stale terminal test stubs/expectations to current runtime Three pre-existing perf-branch test failures (red before the latest main merge; unrelated to it) — all stale test scaffolding lagging behind perf-branch features, no production code changed: - provider-dispatch.test.ts: electron mock missing powerMonitor, which pty.ts installPowerSignalBreadcrumbs now calls on registerPtyHandlers. Added powerMonitor:{on:vi.fn()} to match pty.test.ts. - runtime-terminal-stream.test.ts: onSnapshot now receives a second { pendingEscapeTailAnsi } meta arg (#7329); updated the three exact-arg toHaveBeenCalledWith assertions. - terminal-multiplex-escape-tail.test.ts: stubRuntime missing registerRemoteTerminalViewSubscriber (subscribe path calls it now, erroring before snapshot serialize); added the stub used by sibling multiplex tests. Co-authored-by: Orca <help@stably.ai> * Fix hidden/parked split-pane exit stranding ghost or resurrected panes Deterministic e2e repro of the field 'ghost blank pane' incident (a closed/finished setup-split leaf persisted in root with no binding and remounted as a permanently blank pane) found two teardown gaps at the hidden-view parking boundary: 1. The kept-exit guard ('freshly split pane can lose its newborn PTY during setup') fired for HIDDEN panes. The hidden-delivery gate withholds their bytes, so a hidden split always looks output-less and its dead pane was kept — a binding-less ghost that dead-session reconcile can never reach (no PTY id to prove dead). The keep is a visible-failure UX; gate it on isVisibleRef and close hidden panes. 2. A PTY exit landing while the tab is PARKED reached only the parked watcher's exit sidecar (hosts' onPtyExit requires a mounted TerminalPane), which only disposed the watcher. The leaf's stale binding then reattached on reveal and the daemon re-created the exited session id as a fresh shell — silent pane resurrection. The sidecar now collapses the dead leaf out of the stored layout via detachTerminalLayoutLeaf (the observed-exit teardown's data half). New e2e suite terminal-pane-close-layout-consistency.spec.ts sweeps close/shell-exit at every hidden/park lifecycle phase and asserts leaves(root) == bindings == live panes; all 7 scenarios pass. Unit regressions added for both fixes. Co-authored-by: Orca <help@stably.ai> * Harden terminal delivery and snapshot recovery Co-authored-by: Orca <help@stably.ai> * Fix inherited lint failures Co-authored-by: Orca <help@stably.ai> * Align merged runtime recovery tests Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com> Co-authored-by: Neil <neil@stably.ai> Co-authored-by: Orca <help@stably.ai>
* Fix WSL Codex hook path trust lifecycle * fix(codex): keep WSL hook trust across transient path rechecks Failed async wslpath/readlink revalidation no longer drops the last known-good cache or wipes managed trust. That path turned cold/wedged distro timeouts into silent untrusted hooks, and forced the next launch onto the logical /mnt guess under custom automount roots. Settlement now reinstalls only when the generation is current and the canonical trust path actually changed. * fix(codex): revoke trust for missing WSL hook paths
* Handle locked worktree force deletion Co-authored-by: Orca <help@stably.ai> * Harden locked worktree removal * Recover Windows worktree deletion after Git deregisters * Require force permission for lock overrides * Respect Git worktree locks during deletion * Require structural proof before Windows deletion recovery * Align deletion tests with fail-closed recovery * Restore deletion test filesystem spies * Scope remote deletion tests to runtime host --------- Co-authored-by: Orca <help@stably.ai>
* fix(terminal): ignore title-only idle while hooks are active * fix(terminal): preserve hook authority across title races Co-authored-by: Orca <help@stably.ai> * fix(terminal): preserve confirmed process-exit notifications Co-authored-by: Orca <help@stably.ai> * fix(terminal): preserve authoritative agent lifecycle Co-authored-by: Orca <help@stably.ai> * fix(agent-status): keep lifecycle tracking bounded and ordered Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com> Co-authored-by: Orca <help@stably.ai>
…literal list (#7971) * fix(agent-status): filter harness-injected turns by tag shape, not a literal list Harness machinery turns (task-notification, agent-message, bash-input/stdout, system-reminder, …) were leaking into prompt-derived UI as if the user typed them — hook-status labels, native-chat bubbles, and AI Vault session titles. The literal tag blocklist went stale twice in three months because the harness adds tags faster than we chase them. Generalize the text classifier to match the harness's tag *shape*: any prompt beginning with a lowercase multi-word kebab tag (<task-notification>, <agent-message …>, <bash-input>, …) is machinery. Underscore tags (<user_query>) are deliberately excluded — Grok wraps real typed prompts in them. Explicit prefixes remain only for the single-word tag (<channel source=) and the prose wrappers the harness uses. Add a structural drop at the native-chat decoder (user turns marked isMeta/isSynthetic/isCompactSummary, unless they carry tool results) and gate AI Vault title seeding on the shared classifier, since task-notifications carry no isMeta. * fix(native-chat): avoid hiding user markup --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
* fix(browser): snapshot Chromium cookie WAL safely * fix(browser): clean partial cookie staging copies
* fix(source-control): stop measuring layout on every virtual list render Shared-scroller scrollMargin used a deps-less useLayoutEffect that called getBoundingClientRect after every React render (including git-status polls). Measure on mount/attach only, then refresh via ResizeObserver and childList MutationObserver with cleanup, and add focused tests for no render-time layout reads plus multi-section margin updates. * fix(source-control): prune stale layout observers
* fix(git): cache unsupported capabilities per host Old Git worktree, ref-search, and merge-tree fallbacks retried unsupported flags on recurring operations, flooding subprocess traces. Centralize capability probing per native, WSL, and SSH execution host, coalesce concurrent probes, and retry periodically for in-place Git upgrades. * fix(git): recognize real old-Git merge-tree rejection * test(git): enforce real binary compatibility matrix * fix(ci): preserve Git compatibility test ownership * fix(git): retain supported capability state
* fix: keep dispatch task preview after single-line status normalization Agent-status prompts fold multi-KB dispatch preambles to ~200 single-line chars, which previously kept only lifecycle boilerplate and dropped the TASK body. Compact dispatch prompts to preserve task id + body, extract that as the UI fallback before orchestration labels arrive, and prefer richer labels once they match the live dispatch. * fix: harden dispatch status prompt compaction * fix: share dispatch task-marker parsing with UI preview helpers Round-2 adversarial review found getOrcaDispatchTaskPreview still used naive indexOf, so raw multi-line preambles with base-drift subjects mentioning === TASK === could surface the wrong fallback label. Export the standalone-line marker finder and use it on both compaction and UI preview paths, with regression coverage for raw and single-line forms.
Multiplexer/session wrappers prefix pane titles as "prefix | pane-title", pushing the Pi/OMP identity after " | ". Inspect each " | " suffix and prefer a re-ownable compatible identity over the wrapper text, so wrapped OMP/Pi titles normalize to the owner instead of flickering. Includes guard tests for braille-inner labels and no-identity wrappers.
* Fix provider account discovery isolation * fix(review): mark remote WSL provider accounts active correctly Remote Windows lists host and WSL accounts together, but Active used the forced host selection only, so selected WSL accounts never lit. Scope Active to each account's own runtime slot, and cover reverse partial-load failures. * fix(review): scope remote WSL account restart checks * Fix WSL default-account row highlighting a stale "System default" badge - The forced-host activeAccountId (Codex/Claude) could show as active alongside a genuinely active WSL account when a WSL distro is flattened to host scope, since the host default id stays null in that case. - Derive activity from whether any visible row is active instead, and share a WSL_DEFAULT_DISTRO_KEY sentinel between the distro Select and the active-id resolver so they can't drift out of sync. * Fix provider account isolation and remove-dialog stale state bugs - Treat a failed provider's substituted empty roster as non-authoritative in fetchProviderAccountsSnapshot/watchProviderAccounts consumers (AccountsPane, StatusBar switchers), so a Codex/Claude fetch failure no longer wipes out the healthy provider's list or shows a false empty state. - Capture the account's runtime slot when the remove-account dialog opens (removeCodexTarget/removeClaudeTarget) instead of re-deriving it from the live roster on confirm, since the roster can change underneath an open dialog and misroute the restart check. - Compute "System default" active state against the full account roster when a remote owner's platform is unknown, since WSL rows fail-closed and hide from the visible list in that case. - Guard the deferred onError emission with a closed check so an onSnapshot handler that closes the watcher doesn't trigger a second error callback.
#6303) * feat(cli): make the CLI self-correcting and self-describing for agents Agents build a generalized model of how CLIs work and apply it to every tool. When orca diverged — `rm` where git uses `remove` — a reasonable first guess (`orca worktree remove`) dead-ended on a bare "Unknown command" with no path forward. This makes the CLI degrade gracefully when the orca-cli skill isn't loaded in context. - First-class CommandSpec.aliases, resolved to the canonical path before dispatch (no new handler registrations). `worktree remove`/`delete` now resolve to `rm`; the ad-hoc `terminal focus` duplicate spec/handler is migrated onto the mechanism. - Did-you-mean suggestions on unknown commands and unknown flags, ranked by edit distance over the live registry, surfaced in both stderr and --json error.data (reusing the existing nextSteps channel). - `orca agent-context [--json]`: a versioned, machine-readable dump of the command schema. Pure local read (no RPC), so it works over SSH and when the app isn't running. - CI guards: specs<->handlers parity, and a vocabulary policy that fails on new off-policy deletion/read verbs (existing ones grandfathered). * Address PR review feedback (#6303) - agent-context now emits each command's effective flag set (globals + conditional --page), not just allowedFlags, so the schema no longer under-reports --json/--help. Shared as effectiveAllowedFlags() between validation and the schema. - Collision check now covers alias paths too, so a duplicate alias that would silently shadow a real command fails the build. * fix(cli): harden agent recovery and introspection Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com> Co-authored-by: Orca <help@stably.ai>
* fix(linear): guard mixed-version RPC filtering * fix(linear): surface filter capability failures correctly Prevent capability checks from pinning to rejected compatibility cache entries, and rethrow typed attribute-filter unsupported errors from the Linear store so TaskPage can show an upgrade message instead of an empty filtered list. * fix(runtime): refresh cached capability verdicts * test(linear): mock isLinearIssueAttributeFilterUnsupportedError Prevents the invalidation slice test from failing after the runtime client gained this export, which was otherwise undefined in the mock. * Fix cold-cache capability probes firing duplicate status.get calls Coalesce concurrent status.get requests for the same environment by publishing the in-flight probe to the compatibility cache before awaiting it, so parallel capability checks share one RPC call. On failure, drop the cache entry immediately since this probe always re-fetches and must not leave a stale cached verdict.
* fix(cleanup): reconcile late removal results * fix(cleanup): report authoritative late removals
…e and updated (#7959) * fix(jira): add sortable columns to Jira issues in task page Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * test(jira): add comprehensive tests for Jira issue sorting functionality Add test coverage for the new Jira issue sorting features including: - Priority weight calculation with fallback logic - Sorting by key, title, priority, assignee, and updated date - Issue grouping and section ordering after sorting - Handling of edge cases like unassigned assignees and unknown priorities Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix: resolve coderabbit review comments on jira issue sorting - Extract getJiraPriorityWeight and sorting logic into a shared jira-issue-sorter module. - Fix grid column definitions on md viewports in TaskPage.tsx. - Implement cancelled flags in useEffect hooks in TaskPage.tsx to guard against stale responses. - Swapped priority weights mapping to blocker=99, lowest=1, missing=0 to sort ascending from lowest-to-highest priority using weightA - weightB. - Focus-ring enhancements on sort button headers and aria-expanded/chevron fix on collapsible groups. - Remove duplicate helpers from unit tests and verify the new sorting expectations. * fix(jira): harden issue sorting review gaps --------- Co-authored-by: Andres Van Reepingen <andres.vanreepingen@datacamp.com> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
* Redesign mobile search field as a shared, raised component - Extract MobileSearchField from duplicated Search icon + TextInput + clear button markup in worktree list and tasks screens into a reusable component - Give the field a raised bgRaised shell with focus/disabled states so it reads as a tappable control instead of blending into panel chrome - Fix delayed autoFocus via InteractionManager + timeout so the keyboard reliably appears after the search bar opens - Preserve per-screen clear behavior (preset/query fallback for GitHub, project-view filter) via configurable showClear/onClear props * Simplify GitHub project search state checks and fix stuck clear button - Extract `isGithubProjectSearch` to dedupe repeated `provider === 'github' && githubMode === 'project'` checks - Fix showClear so an explicit empty applied override doesn't leave the clear button visible forever
…ck (#8200) Previously a failed resize during reclaimTerminalForDesktop left the override/lock in place (#7588 semantics), but for an explicit "take back all terminals" gesture that could strand banners on background panes whose resize can't converge. Now the take-back unconditionally releases the driver and clears any held fit-override via a new releaseDesktopTakeBack helper, while auto-restore and phone-initiated paths keep the original keep-lock-on-failure behavior. Also extract the local mapWithConcurrency helper out of workspace-cleanup.ts into a shared, tested src/shared/map-with-concurrency.ts and use it to bound concurrent desktop-fit reclaims in terminal-fit-restore.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )