Skip to content

🧪 Add test for DomainFilter invalid hostname fallback #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saurabhsharma2u merged 1 commit into from
Feb 25, 2026
Merged

🧪 Add test for DomainFilter invalid hostname fallback #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/core/tests/scope.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ describe('DomainFilter', () => {
const filter = new DomainFilter(['allowed.com']);
expect(filter.isAllowed('other.com')).toBe(false);
});

it('should fallback to raw string on invalid hostname', () => {
// '[' and 'http://denied-invalid-[' causes new URL() to throw
const filter = new DomainFilter(['['], ['denied-invalid-[']);
expect(filter.isAllowed('[')).toBe(true);
expect(filter.isAllowed('denied-invalid-[')).toBe(false);
});
});

describe('SubdomainPolicy', () => {
Expand Down
Loading