Skip to content

Improve test coverage for core modules#48

Merged
saurabhsharma2u merged 2 commits into
mainfrom
test-coverage-improvement-5307495361093038445
Feb 26, 2026
Merged

Improve test coverage for core modules#48
saurabhsharma2u merged 2 commits into
mainfrom
test-coverage-improvement-5307495361093038445

Conversation

@saurabhsharma2u

Copy link
Copy Markdown
Contributor

This PR significantly improves test coverage for @crawlith/core by adding unit tests for previously uncovered or under-tested modules.

Key additions:

  • Audit Module: Full coverage for auditUrl orchestration logic.
  • Database: Unit tests for PageRepository (including chunking logic) and db/index.ts (environment config).
  • Graph: Unit tests for Graph data structure manipulation and serialization.
  • LockManager: Tests for process signal handlers and cleanup logic.
  • Analysis: Extended tests for structured data parsing (JSON-LD arrays).
  • Scope: Tests for trailing dot normalization in domain scope.

All tests use in-memory databases and mocks to ensure isolation and speed.


PR created automatically by Jules for task 5307495361093038445 started by @saurabhsharma2u

…lysis modules

Added comprehensive unit tests for:
- `auditUrl` in `audit/index.ts`
- `PageRepository` methods (`getPagesByUrls`, `getPagesIteratorBySnapshot`, `upsertAndGetId`)
- `Graph` class methods (`addNode`, `addEdge`, `fromJSON`)
- `LockManager` signal handling (`SIGINT`, `SIGTERM`, `uncaughtException`)
- `analyzeStructuredData` edge cases (arrays, `@graph`)
- `getDbPath` and `getDb` environment handling in `db/index.ts`
- `ScopeManager` trailing dot handling

Verified with `pnpm test --coverage` showing significant improvement in affected modules.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@saurabhsharma2u
saurabhsharma2u marked this pull request as ready for review February 26, 2026 15:14
@saurabhsharma2u
saurabhsharma2u merged commit 0293e27 into main Feb 26, 2026
6 checks passed
@saurabhsharma2u
saurabhsharma2u deleted the test-coverage-improvement-5307495361093038445 branch February 26, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant