Skip to content

Refactor sitegraph HTML generation logic#46

Closed
saurabhsharma2u wants to merge 1 commit into
mainfrom
code-health-sitegraph-html-refactor-18157046508373459264
Closed

Refactor sitegraph HTML generation logic#46
saurabhsharma2u wants to merge 1 commit into
mainfrom
code-health-sitegraph-html-refactor-18157046508373459264

Conversation

@saurabhsharma2u

Copy link
Copy Markdown
Contributor

Consolidated sitegraph visualization logic by moving generateHtml into sitegraphExport.ts and renaming it to renderSitegraphHtml. This unifies all sitegraph export functions (CSV, Markdown, HTML) into a single module, improving maintainability and consistency. The safeJson helper was also moved to support secure JSON injection.


PR created automatically by Jules for task 18157046508373459264 started by @saurabhsharma2u

- Moved `generateHtml` logic from `plugins/core/src/report/html.ts` to `plugins/core/src/report/sitegraphExport.ts`.
- Renamed `generateHtml` to `renderSitegraphHtml` for consistency with other export functions.
- Deleted `plugins/core/src/report/html.ts`.
- Updated `@crawlith/core` exports.
- Updated `@crawlith/cli` to use the new `renderSitegraphHtml` function.
- Preserved `safeJson` logic as a private helper in `sitegraphExport.ts`.
- Updated tests in both packages.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@saurabhsharma2u

Copy link
Copy Markdown
Contributor Author

Closing as this refactoring was already completed and merged in PR 29 / 37. The generateHtml logic has already been successfully migrated to renderSitegraphHtml in sitegraphExport.ts.

@saurabhsharma2u

Copy link
Copy Markdown
Contributor Author

Closing as this refactoring was already completed and merged. The generateHtml logic has already been successfully migrated to renderSitegraphHtml in sitegraphExport.ts.

@saurabhsharma2u
saurabhsharma2u deleted the code-health-sitegraph-html-refactor-18157046508373459264 branch February 25, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant