Consolidate graph visualization logic into sitegraphExport.ts#45
Consolidate graph visualization logic into sitegraphExport.ts#45saurabhsharma2u wants to merge 2 commits into
Conversation
- Moved `generateHtml` from `plugins/core/src/report/html.ts` to `plugins/core/src/report/sitegraphExport.ts`. - Renamed `generateHtml` to `renderSitegraphHtml` for consistency with other export functions. - Moved `safeJson` helper to `sitegraphExport.ts`. - Deleted `plugins/core/src/report/html.ts`. - Updated `plugins/cli` and tests to use the new function name and import path. - Updated `@crawlith/core` exports.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `packageManager` field to `package.json` with `pnpm@9.15.4`. - Removed explicit `version: 10` from `.github/workflows/ci.yml` to allow `pnpm/action-setup` to use the pinned version. - This resolves `ERR_PNPM_FETCH_403` errors seen in CI when attempting to install unstable/problematic pnpm v10 versions.
|
Closing as a duplicate of PR 46 which addresses the exact same refactoring task, but PR 46 has a cleaner history. |
1 participant
Addressed the code health issue "Duplicated Graph Visualization Code" by consolidating the HTML generation logic into
sitegraphExport.tsand renaming the function torenderSitegraphHtml. This unifies the sitegraph export logic (HTML, CSV, Markdown) into a single module and removes the single-purposehtml.tsfile. Verified with tests in both core and cli packages.PR created automatically by Jules for task 5047483803518301596 started by @saurabhsharma2u