Refactor SimHash banding logic into shared utility#44
Conversation
- Added `SimHash.groupIntoBands` static method. - Updated `cluster.ts` to use the new utility. - Updated `duplicate.ts` to use the new utility.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as this PR conflicts with the recent high-performance memory optimizations merged in PR 32. PR 32 rewrote to use flat |
Refactored the duplicated SimHash banding logic found in
plugins/core/src/graph/cluster.tsandplugins/core/src/graph/duplicate.tsinto a new static methodSimHash.groupIntoBandsinplugins/core/src/graph/simhash.ts. This improves code maintainability and reduces duplication. Confirmed that existing tests inclustering.test.tsandduplicate.test.tspass.PR created automatically by Jules for task 6286707582081801071 started by @saurabhsharma2u