🧹 Refactor HTML report templates into separate files#29
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Extracted embedded HTML from `plugins/core/src/analysis/analyze.ts` into `analysis_list.html` and `analysis_page.html`. - Created `plugins/core/src/analysis/templates.ts` to load templates. - Updated `plugins/core/scripts/copy-assets.js` to copy new HTML assets to dist. - Added `plugins/core/tests/html_report.test.ts` to verify HTML report generation. - Fixed linting issues in `copy-assets.js`.
e6ad445 to
d79cb7f
Compare
|
Review complete ✅. Aligns perfectly with the refactoring roadmap goals. Separation of concerns by moving embedded HTML into individual templates vastly improves readability and maintainability. Rebased onto main, verified all tools and tests work correctly. Merging. |
1 participant
Moved embedded HTML templates from
plugins/core/src/analysis/analyze.tsto separate.htmlfiles to improve maintainability and readability. This addresses the code health issue of large embedded HTML strings in TypeScript files.The templates are now loaded at runtime using
fs.readFileSync, similar to the existingsitegraph_template.tspattern.Also added unit tests to ensure the generated HTML structure remains correct.
PR created automatically by Jules for task 18439780174040486280 started by @saurabhsharma2u