Refactor duplicated SimHash banding logic#21
Conversation
- Added `SimHash.getBands(simhash: bigint): number[]` to `plugins/core/src/graph/simhash.ts` - Added `SimHash.BANDS` and `SimHash.BAND_WIDTH` constants - Updated `plugins/core/src/graph/cluster.ts` to use the new utility method and constants - Updated `plugins/core/src/graph/duplicate.ts` to use the new utility method and constants - Verified changes with existing tests `clustering.test.ts` and `duplicate.test.ts`
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses a code health issue where SimHash banding logic was duplicated between
plugins/core/src/graph/cluster.tsandplugins/core/src/graph/duplicate.ts.I have created a shared utility method
SimHash.getBandsand constants inplugins/core/src/graph/simhash.tsand updated both consumer files to use it. This improves maintainability and reduces code duplication.Verification:
pnpm testinplugins/coreand all relevant tests passed.PR created automatically by Jules for task 8619560933874571708 started by @saurabhsharma2u