Skip to content

test: add error handling test for extractLinks#18

Merged
saurabhsharma2u merged 1 commit into
mainfrom
test/extract-cheerio-error-handling-3214724274036011544
Feb 25, 2026
Merged

test: add error handling test for extractLinks#18
saurabhsharma2u merged 1 commit into
mainfrom
test/extract-cheerio-error-handling-3214724274036011544

Conversation

@saurabhsharma2u

Copy link
Copy Markdown
Contributor

This PR improves the testing of the extractLinks function in @crawlith/core.

Changes:

  • Created plugins/core/tests/extract.test.ts.
  • Moved extractLinks test from plugins/core/tests/normalize.test.ts to the new file.
  • Added a test case that mocks cheerio.load to throw an error, verifying that extractLinks returns an empty array and logs the error as expected.
  • Verified that all tests pass.

PR created automatically by Jules for task 3214724274036011544 started by @saurabhsharma2u

Added a new test file `plugins/core/tests/extract.test.ts` to test `extractLinks` function.
Moved the existing test case from `plugins/core/tests/normalize.test.ts` to the new file.
Added a new test case that mocks `cheerio.load` to throw an error and asserts that `extractLinks` handles it gracefully.
This improves test coverage and ensures robustness against parser errors.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@saurabhsharma2u
saurabhsharma2u marked this pull request as ready for review February 25, 2026 15:16
@saurabhsharma2u
saurabhsharma2u merged commit 6036256 into main Feb 25, 2026
6 checks passed
@saurabhsharma2u
saurabhsharma2u deleted the test/extract-cheerio-error-handling-3214724274036011544 branch February 25, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant