Refactor Sitegraph Template to Separate File#17
Conversation
- Extracted embedded HTML string from `plugins/core/src/report/sitegraph_template.ts` to `plugins/core/src/report/sitegraph.html`. - Updated `sitegraph_template.ts` to read the HTML file content at runtime using `fs.readFileSync`. - Added `plugins/core/scripts/copy-assets.js` to handle copying the HTML file to `dist` directory during build. - Updated `plugins/core/package.json` build script to execute the copy script. - Fixed escaping issues in the HTML template that were artifacts of TS template literal usage. - Verified functionality with existing tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Moved the large HTML template embedded in
sitegraph_template.tsto a dedicatedsitegraph.htmlfile. This improves code readability and allows for proper syntax highlighting and linting of the HTML/JS/CSS content. The build process was updated to ensure the template file is copied to the distribution folder, preserving existing functionality.PR created automatically by Jules for task 3978396734452674406 started by @saurabhsharma2u