Skip to content

Refactor duplicated graph visualization code in html report#12

Merged
saurabhsharma2u merged 1 commit into
mainfrom
refactor-html-report-duplication-11969879025056150495
Feb 25, 2026
Merged

Refactor duplicated graph visualization code in html report#12
saurabhsharma2u merged 1 commit into
mainfrom
refactor-html-report-duplication-11969879025056150495

Conversation

@saurabhsharma2u

Copy link
Copy Markdown
Contributor

This change addresses the code health issue of duplicated graph visualization code.

The generateHtml function in plugins/core/src/report/html.ts previously contained a duplicated and simpler implementation of the graph visualization. This has been refactored to use the more robust SITEGRAPH_HTML template from plugins/core/src/report/sitegraph_template.ts.

Key changes:

  1. generateHtml now injects graphData and metrics into SITEGRAPH_HTML instead of generating its own HTML.
  2. graphData is sanitized (HTML content removed) before injection to keep the file size manageable.
  3. sitegraph_template.ts was updated to display session crawl statistics (fetched/cached pages), ensuring no regression in the information provided by the report.
  4. Tests in html_report.test.ts were updated to verify the correct data injection.

This consolidation reduces maintenance overhead and provides a better visualization experience for the HTML report.


PR created automatically by Jules for task 11969879025056150495 started by @saurabhsharma2u

- Consolidate visualization logic by using `SITEGRAPH_HTML` template in `generateHtml`.
- Sanitize `graphData` in `generateHtml` to reduce report size (removing `html` property).
- Inject data via `window.GRAPH_DATA` and `window.METRICS_DATA`.
- Update `SITEGRAPH_HTML` to display session stats (fetched/cached) to maintain feature parity with the old report.
- Update tests to reflect the new implementation.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@saurabhsharma2u
saurabhsharma2u marked this pull request as ready for review February 25, 2026 14:46
@saurabhsharma2u
saurabhsharma2u merged commit 9e0cadb into main Feb 25, 2026
6 checks passed
@saurabhsharma2u
saurabhsharma2u deleted the refactor-html-report-duplication-11969879025056150495 branch February 25, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant