Refactor: Remove redundant p-limit concurrency control#11
Conversation
The crawler was using both a manual `active` counter and `p-limit` for concurrency control. The manual counter logic ensures that no more than `concurrency` tasks are ever active, making the `p-limit` wrapper redundant as it would never queue tasks. This change: - Removes `p-limit` usage in `plugins/core/src/crawler/crawl.ts`. - Removes `p-limit` from `plugins/core/package.json`. - Simplifies the `crawl` function by directly calling `processPage`. This improves code clarity and reduces dependencies without changing behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR removes the redundant
p-limitdependency from the crawler implementation in@crawlith/core. The crawler already implements manual concurrency control using anactivecounter loop, which effectively limits the number of concurrent tasks. Thep-limitwrapper was therefore unnecessary and has been removed to simplify the code and reduce dependencies.Changes:
p-limitimport and usage inplugins/core/src/crawler/crawl.ts.p-limitfromplugins/core/package.json.pnpm-lock.yaml.Verification:
tests/crawler.test.tsand confirmed all tests passed.pnpm lintand confirmed no new linting issues.pnpm buildsucceeds.PR created automatically by Jules for task 2409713938351617354 started by @saurabhsharma2u