Skip to content

Align uninstall log cleanup with actual logs directory#309

Open
DDDDDGCSM wants to merge 1 commit into
CortexLM:mainfrom
DDDDDGCSM:fix-53185-real-logs-dir
Open

Align uninstall log cleanup with actual logs directory#309
DDDDDGCSM wants to merge 1 commit into
CortexLM:mainfrom
DDDDDGCSM:fix-53185-real-logs-dir

Conversation

@DDDDDGCSM
Copy link
Copy Markdown

Summary

  • make cortex logs resolve its directory via AppDirs instead of hand-building a cache path
  • make cortex uninstall enumerate the same real logs directory used by cortex logs
  • add focused regression tests covering cache-backed logs removal

Verification

  • cargo check -p cortex-cli
  • git diff --check

Notes

  • I attempted targeted cargo test, but the workspace currently has an unrelated pre-existing error in src/cortex-cli/src/agent_cmd/tests.rs (read_file_with_encoding private import), so full test execution is not clean in this environment.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant