Skip to content

fix: highlight device login copy action#289

Open
SlaVKsVolks wants to merge 1 commit into
CortexLM:mainfrom
SlaVKsVolks:codex/login-copy-action-style
Open

fix: highlight device login copy action#289
SlaVKsVolks wants to merge 1 commit into
CortexLM:mainfrom
SlaVKsVolks:codex/login-copy-action-style

Conversation

@SlaVKsVolks
Copy link
Copy Markdown

Summary

  • promotes the device-login c shortcut to a primary action-bar item
  • keeps Enter as an alternate copy hint without merging it into the same dim Enter/c label
  • adds coverage that pending login key hints expose Enter and c separately

Fixes PlatformNetwork/bounty-challenge#53260.

Verification

  • rustfmt --edition 2024 --check src/cortex-tui/src/modal/login.rs
  • cargo test -p cortex-tui modal::login::tests::test_pending_key_hints_split_copy_keys
  • cargo test -p cortex-tui modal::login::tests::test_key_handling_pending
  • cargo check -p cortex-tui
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] Device login “c to copy” uses the same DIM style as the rest of the hint line

1 participant