3D: Fixed MVC PGS subtitles have no depth#58
Open
boeschy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
3D MVC PGS subtitles had no depth because the depth info never had been carried over to the videoplayer. Also a logical error is fixed which led GetStereoscopicDepth to always return 0 depth for PGS subtitles.
Motivation and context
It is much more comfortable if 3D subtitles are shown with the intended depth.
How has this been tested?
Several 3D BD ISOs with subtitles turned on.
What is the effect on users?
3D MVC PGS subtitles are shown with the correct depth.
Screenshots (if appropriate):
Types of change
Checklist: