Skip to content

3D: Fixed MVC PGS subtitles have no depth#58

Open
boeschy wants to merge 1 commit into
CoreELEC:aml-5.15.196-22.0from
boeschy:flatpgssubsfix
Open

3D: Fixed MVC PGS subtitles have no depth#58
boeschy wants to merge 1 commit into
CoreELEC:aml-5.15.196-22.0from
boeschy:flatpgssubsfix

Conversation

@boeschy

@boeschy boeschy commented Jun 16, 2026

Copy link
Copy Markdown

Description

3D MVC PGS subtitles had no depth because the depth info never had been carried over to the videoplayer. Also a logical error is fixed which led GetStereoscopicDepth to always return 0 depth for PGS subtitles.

Motivation and context

It is much more comfortable if 3D subtitles are shown with the intended depth.

How has this been tested?

Several 3D BD ISOs with subtitles turned on.

What is the effect on users?

3D MVC PGS subtitles are shown with the correct depth.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant