Skip to content

3D: Fixed wrong aspect ratio for HTAB and HSBS videos#57

Closed
boeschy wants to merge 1 commit into
CoreELEC:aml-5.15.196-22.0from
boeschy:hsbshtabfix
Closed

3D: Fixed wrong aspect ratio for HTAB and HSBS videos#57
boeschy wants to merge 1 commit into
CoreELEC:aml-5.15.196-22.0from
boeschy:hsbshtabfix

Conversation

@boeschy

@boeschy boeschy commented Jun 16, 2026

Copy link
Copy Markdown

Description

Commit de94434 caused a regression to HSBS/HTAB video playback aspect ratio. Since HSBS videos always have a width <= 1920 and HTAB videos always have a height <= 1080, the previous dar calculation is used for those. Otherwise the videos are FSBS or FTAB and the calculation introduced with de94434.

Motivation and context

This commit fixes the wrong dar calculation for HSBS/HTAB videos.

How has this been tested?

Several 720p/1080p HSBS/HTAB and a FTAB video

What is the effect on users?

FSBS/HTAB and HSBS/HTAB video playback has the correct aspect ratio.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Portisch

Copy link
Copy Markdown
Contributor

Closed by xbmc/xbmc#28452.
Fix will be picked until it get merged into xbmc/master.

@Portisch Portisch closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants