3D: Fixed wrong aspect ratio for HTAB and HSBS videos#57
Closed
boeschy wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closed by xbmc/xbmc#28452. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit de94434 caused a regression to HSBS/HTAB video playback aspect ratio. Since HSBS videos always have a width <= 1920 and HTAB videos always have a height <= 1080, the previous
darcalculation is used for those. Otherwise the videos are FSBS or FTAB and the calculation introduced withde94434.Motivation and context
This commit fixes the wrong
darcalculation for HSBS/HTAB videos.How has this been tested?
Several 720p/1080p HSBS/HTAB and a FTAB video
What is the effect on users?
FSBS/HTAB and HSBS/HTAB video playback has the correct aspect ratio.
Screenshots (if appropriate):
Types of change
Checklist: