Skip to content

web: suppress the browser default on held-key auto-repeats #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinuxJedi merged 2 commits into from
Jul 23, 2026
+22 −3
Merged

web: suppress the browser default on held-key auto-repeats #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8eb510
web: suppress the browser default on held-key auto-repeats
LinuxJedi Jul 23, 2026
ed8183b
web: keep the consumed-key set from going stale across stop or blur
LinuxJedi Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions crates/copperline-web/www/try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,13 +996,32 @@ function updatePadStatus(releasedPort1) {

// --- keyboard ------------------------------------------------------------

// Auto-repeat keydowns must not reach the emulator (the Amiga keyboard
// sends one down code; the guest OS does its own repeat), but the browser
// default still has to be suppressed on every repeat or holding a cursor
// key scrolls the page. Track which codes the first keydown consumed.
const consumedKeys = new Set();
window.addEventListener('keydown', (e) => {
if (!emu || !running || e.repeat) return;
if (joystickKey(e.code, true) || emu.key_event(e.code, true)) e.preventDefault();
if (!emu || !running) return;
if (e.repeat) {
if (consumedKeys.has(e.code)) e.preventDefault();
return;
}
if (joystickKey(e.code, true) || emu.key_event(e.code, true)) {
consumedKeys.add(e.code);
e.preventDefault();
} else {
consumedKeys.delete(e.code);
}
});
window.addEventListener('keyup', (e) => {
// Delete before the running check: a hold that spans an emulator stop
// or a focus loss must not leave a stale entry behind.
const consumed = consumedKeys.delete(e.code);
if (!emu || !running) return;
if (joystickKey(e.code, false) || emu.key_event(e.code, false)) e.preventDefault();
if (joystickKey(e.code, false) || emu.key_event(e.code, false) || consumed) {
e.preventDefault();
}
});

// --- mouse ---------------------------------------------------------------
Expand Down
Loading