Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
- [FE] ๐Ÿ“‹ **ํ…Œ์ด๋ธ” ๋ณต์ œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€**: ํŽธ์ง‘ ๋ชจ๋‹ฌ ๋‚ด์—์„œ ๊ธฐ์กด ํ…Œ์ด๋ธ”์˜ ๊ตฌ์กฐ(์ปฌ๋Ÿผ ์ •๋ณด ํฌํ•จ)๋ฅผ ๊ทธ๋Œ€๋กœ ๋ณต์‚ฌํ•˜์—ฌ ์ƒˆ ํ…Œ์ด๋ธ” ๋…ธ๋“œ๋กœ ์ƒ์„ฑํ•˜๋Š” '๋ณต์ œ' ๋ฒ„ํŠผ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
- [FE] `autoInfer.ts`์— ๋Œ€ํ•œ ๋‹จ์œ„ ํ…Œ์ŠคํŠธ ๋ฐ UI ์ปดํฌ๋„ŒํŠธ ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค.
- [FE] โฌ‡๏ธ **DBML Export**: ERD ๋‹ค์ด์–ด๊ทธ๋žจ์„ DBML (Database Markup Language) ํ˜•์‹์œผ๋กœ ๋‚ด๋ณด๋‚ผ ์ˆ˜ ์žˆ๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์ƒ๋‹จ์˜ DBML ๋ฒ„ํŠผ์„ ํด๋ฆญํ•˜์—ฌ ๋‹ค์šด๋กœ๋“œํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
- [FE] ๐Ÿ“š **Data Dictionary Export**: ERD ํ…Œ์ด๋ธ”/์ปฌ๋Ÿผ ๋ฉ”ํƒ€๋ฐ์ดํ„ฐ๋ฅผ CSV ๋ฐ Markdown์œผ๋กœ ๋‚ด๋ณด๋‚ด๋ฉฐ, CSV formula injection๊ณผ Markdown ๋ Œ๋”๋ง escape๋ฅผ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
21 changes: 21 additions & 0 deletions frontend/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ import {
downloadText,
exportDDL,
exportDiagramSvg,
exportDictionaryCsv,
exportDictionaryMarkdown,
exportPlantUml,
} from "./erd/export";
import { exportMermaid } from "./erd/mermaid";
Expand Down Expand Up @@ -620,6 +622,22 @@ export default function App() {
downloadText("pg-erd-diagram.mermaid", exportMermaid(nodes, edges), "text/plain");
}

function onExportDictionaryCsv() {
downloadText(
"data_dictionary.csv",
exportDictionaryCsv(nodes, edges),
"text/csv;charset=utf-8",
);
}

function onExportDictionaryMarkdown() {
downloadText(
"data_dictionary.md",
exportDictionaryMarkdown(nodes, edges),
"text/markdown;charset=utf-8",
);
}

function onDownloadDbml() {
downloadText("pg-erd-diagram.dbml", exportDbml(nodes, edges), "text/plain");
}
Expand Down Expand Up @@ -1580,6 +1598,7 @@ export default function App() {
isOpen={isExportModalOpen}
isCopied={isCopied}
hasDdlExport={nodes.length > 0}
hasDictionaryExport={nodes.length > 0}
hasDiagramExport={nodes.length > 0}
shareLinkUrl={shareLinkUrl}
isCreatingShareLink={isCreatingShareLink}
Expand All @@ -1591,6 +1610,8 @@ export default function App() {
onDownloadSvg={onDownloadSvg}
onDownloadUml={onDownloadUml}
onDownloadMermaid={onDownloadMermaid}
onExportDictionaryCsv={onExportDictionaryCsv}
onExportDictionaryMarkdown={onExportDictionaryMarkdown}
onCreateShareLink={onCreateShareLink}
onCopyShareLink={onCopyShareLink}
/>
Expand Down
18 changes: 17 additions & 1 deletion frontend/src/components/modals/ExportModal.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const baseProps = {
isOpen: true,
isCopied: false,
hasDdlExport: true,
hasDictionaryExport: true,
hasDiagramExport: true,
shareLinkUrl: '',
isCreatingShareLink: false,
Expand All @@ -19,6 +20,8 @@ const baseProps = {
onDownloadSvg: vi.fn(),
onDownloadUml: vi.fn(),
onDownloadMermaid: vi.fn(),
onExportDictionaryCsv: vi.fn(),
onExportDictionaryMarkdown: vi.fn(),
onCreateShareLink: vi.fn(),
onCopyShareLink: vi.fn(),
};
Expand Down Expand Up @@ -46,6 +49,8 @@ describe('ExportModal', () => {
expect(screen.getByText('SVG ์ด๋ฏธ์ง€')).toBeInTheDocument();
expect(screen.getByText('PlantUML')).toBeInTheDocument();
expect(screen.getByText('Mermaid')).toBeInTheDocument();
expect(screen.getByText('Data Dictionary CSV')).toBeInTheDocument();
expect(screen.getByText('Data Dictionary MD')).toBeInTheDocument();
});

it('copies an already generated share link', () => {
Expand All @@ -71,6 +76,8 @@ describe('ExportModal', () => {
const onDownloadSvg = vi.fn();
const onDownloadUml = vi.fn();
const onDownloadMermaid = vi.fn();
const onExportDictionaryCsv = vi.fn();
const onExportDictionaryMarkdown = vi.fn();

render(
<ExportModal
Expand All @@ -79,18 +86,24 @@ describe('ExportModal', () => {
onDownloadSvg={onDownloadSvg}
onDownloadUml={onDownloadUml}
onDownloadMermaid={onDownloadMermaid}
onExportDictionaryCsv={onExportDictionaryCsv}
onExportDictionaryMarkdown={onExportDictionaryMarkdown}
/>,
);

fireEvent.click(screen.getByRole('button', { name: 'SQL DDL ๋ณต์‚ฌ' }));
fireEvent.click(screen.getByRole('button', { name: 'SVG ์ด๋ฏธ์ง€ ๋‚ด๋ณด๋‚ด๊ธฐ' }));
fireEvent.click(screen.getByRole('button', { name: 'PlantUML ๋‚ด๋ณด๋‚ด๊ธฐ' }));
fireEvent.click(screen.getByRole('button', { name: 'Mermaid ๋‚ด๋ณด๋‚ด๊ธฐ' }));
fireEvent.click(screen.getByRole('button', { name: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ CSV ๋‚ด๋ณด๋‚ด๊ธฐ' }));
fireEvent.click(screen.getByRole('button', { name: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ Markdown ๋‚ด๋ณด๋‚ด๊ธฐ' }));

expect(onCopyExportDdl).toHaveBeenCalledOnce();
expect(onDownloadSvg).toHaveBeenCalledOnce();
expect(onDownloadUml).toHaveBeenCalledOnce();
expect(onDownloadMermaid).toHaveBeenCalledOnce();
expect(onExportDictionaryCsv).toHaveBeenCalledOnce();
expect(onExportDictionaryMarkdown).toHaveBeenCalledOnce();
});

it('shows share link copy or creation errors', () => {
Expand All @@ -109,15 +122,18 @@ describe('ExportModal', () => {
<ExportModal
{...baseProps}
hasDdlExport={false}
hasDictionaryExport={false}
hasDiagramExport={false}
/>,
);

expect(screen.getAllByText('๋จผ์ € ํ…Œ์ด๋ธ”์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”')).toHaveLength(4);
expect(screen.getAllByText('๋จผ์ € ํ…Œ์ด๋ธ”์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”')).toHaveLength(6);
expect(screen.getByRole('button', { name: 'SQL DDL ๋ณต์‚ฌ' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'SVG ์ด๋ฏธ์ง€ ๋‚ด๋ณด๋‚ด๊ธฐ' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'PlantUML ๋‚ด๋ณด๋‚ด๊ธฐ' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Mermaid ๋‚ด๋ณด๋‚ด๊ธฐ' })).toBeDisabled();
expect(screen.getByRole('button', { name: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ CSV ๋‚ด๋ณด๋‚ด๊ธฐ' })).toBeDisabled();
expect(screen.getByRole('button', { name: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ Markdown ๋‚ด๋ณด๋‚ด๊ธฐ' })).toBeDisabled();
});

it('exposes access-control guidance for disabled button', () => {
Expand Down
22 changes: 22 additions & 0 deletions frontend/src/components/modals/ExportModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ interface ExportModalProps {
isOpen: boolean;
isCopied: boolean;
hasDdlExport: boolean;
hasDictionaryExport: boolean;
hasDiagramExport: boolean;
shareLinkUrl: string;
isCreatingShareLink: boolean;
Expand All @@ -16,6 +17,8 @@ interface ExportModalProps {
onDownloadSvg: () => void;
onDownloadUml: () => void;
onDownloadMermaid: () => void;
onExportDictionaryCsv: () => void;
onExportDictionaryMarkdown: () => void;
onCreateShareLink: () => void;
onCopyShareLink: () => void;
}
Expand All @@ -33,6 +36,7 @@ export function ExportModal({
isOpen,
isCopied,
hasDdlExport,
hasDictionaryExport,
hasDiagramExport,
shareLinkUrl,
isCreatingShareLink,
Expand All @@ -44,6 +48,8 @@ export function ExportModal({
onDownloadSvg,
onDownloadUml,
onDownloadMermaid,
onExportDictionaryCsv,
onExportDictionaryMarkdown,
onCreateShareLink,
onCopyShareLink,
}: ExportModalProps) {
Expand Down Expand Up @@ -93,6 +99,22 @@ export function ExportModal({
onExport: onDownloadMermaid,
ariaLabel: 'Mermaid ๋‚ด๋ณด๋‚ด๊ธฐ',
},
{
label: 'Data Dictionary CSV',
description: hasDictionaryExport ? 'ํ…Œ์ด๋ธ”/์ปฌ๋Ÿผ ๋ชฉ๋ก' : '๋จผ์ € ํ…Œ์ด๋ธ”์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”',
buttonLabel: '๋‚ด๋ณด๋‚ด๊ธฐ',
disabled: !hasDictionaryExport,
onExport: onExportDictionaryCsv,
ariaLabel: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ CSV ๋‚ด๋ณด๋‚ด๊ธฐ',
},
{
label: 'Data Dictionary MD',
description: hasDictionaryExport ? '๋งˆํฌ๋‹ค์šด ๋ฌธ์„œ' : '๋จผ์ € ํ…Œ์ด๋ธ”์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”',
buttonLabel: '๋‚ด๋ณด๋‚ด๊ธฐ',
disabled: !hasDictionaryExport,
onExport: onExportDictionaryMarkdown,
ariaLabel: '๋ฐ์ดํ„ฐ ์‚ฌ์ „ Markdown ๋‚ด๋ณด๋‚ด๊ธฐ',
},
];

return (
Expand Down
187 changes: 187 additions & 0 deletions frontend/src/erd/__tests__/exportDataDictionary.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
import type { Edge, Node } from '@xyflow/react';
import { describe, expect, it } from 'vitest';

import type { TableNodeData } from '../convert';
import { exportDictionaryCsv, exportDictionaryMarkdown } from '../exportDataDictionary';

describe('exportDataDictionary', () => {
const nodes: Node<TableNodeData>[] = [
{
id: 'users',
type: 'tableNode',
position: { x: 0, y: 0 },
data: {
title: 'public.users',
comment: 'User accounts',
badges: { pk: true, fk: false },
columns: [
{
column_name: 'id',
data_type: 'integer',
is_pk: true,
is_not_null: true,
column_comment: 'Primary Key',
example_value: 1,
},
{
column_name: 'account_id',
data_type: 'integer',
is_pk: false,
is_not_null: true,
column_comment: null,
example_value: 42,
},
{
column_name: 'email',
data_type: 'varchar',
is_pk: false,
is_not_null: true,
column_comment: null,
example_value: 'test@example.com',
},
],
},
},
{
id: 'accounts',
type: 'tableNode',
position: { x: 0, y: 0 },
data: {
title: 'public.accounts',
comment: null,
badges: { pk: true, fk: false },
columns: [
{
column_name: 'id',
data_type: 'integer',
is_pk: true,
is_not_null: true,
column_comment: null,
example_value: 1,
},
],
},
},
{
id: 'empty_table',
type: 'tableNode',
position: { x: 0, y: 0 },
data: {
title: 'empty_table',
comment: null,
badges: { pk: false, fk: false },
columns: [],
},
},
];

const edges: Edge[] = [
{
id: 'fk_users_accounts',
source: 'users',
target: 'accounts',
data: { sourceColumns: ['account_id'], targetColumns: ['id'] },
},
];

it('exports table and column metadata to CSV', () => {
const csv = exportDictionaryCsv(nodes, edges);

expect(csv).toContain('"Table Name","Table Comment","Column Name","Data Type","PK","FK","Not Null","Column Comment","Example Value"');
expect(csv).toContain('"public.users","User accounts","id","integer","Y","N","Y","Primary Key","1"');
expect(csv).toContain('"public.users","User accounts","account_id","integer","N","Y","Y","","42"');
expect(csv).toContain('"public.users","User accounts","email","varchar","N","N","Y","","test@example.com"');
expect(csv).toContain('"empty_table","","","","","","","",""');
});

it('handles empty CSV exports', () => {
expect(exportDictionaryCsv([], edges)).toBe(
'"Table Name","Table Comment","Column Name","Data Type","PK","FK","Not Null","Column Comment","Example Value"',
);
});

it('neutralizes CSV formula injection and normalizes control characters', () => {
const csv = exportDictionaryCsv(
[
{
id: 'attack',
type: 'tableNode',
position: { x: 0, y: 0 },
data: {
title: '=HYPERLINK("https://example.invalid")',
comment: '@note\r\nsecond line',
badges: { pk: false, fk: false },
columns: [
{
column_name: '+cmd',
data_type: '-integer',
is_pk: false,
is_not_null: false,
column_comment: '@comment',
example_value: '\t=2+2',
},
],
},
},
],
[],
);

expect(csv).toContain('"\'=HYPERLINK(""https://example.invalid"")"');
expect(csv).toContain('"\'@note second line"');
expect(csv).toContain('"\'+cmd"');
expect(csv).toContain('"\'-integer"');
expect(csv).toContain('"\'@comment"');
expect(csv).toContain('"\' =2+2"');
});

it('exports table and column metadata to Markdown', () => {
const markdown = exportDictionaryMarkdown(nodes, edges);

expect(markdown).toContain('# Data Dictionary');
expect(markdown).toContain('## Table: public.users (User accounts)');
expect(markdown).toContain('| id | integer | Y | N | Y | Primary Key | 1 |');
expect(markdown).toContain('| account_id | integer | N | Y | Y | | 42 |');
expect(markdown).toContain('## Table: empty_table');
expect(markdown).toContain('No columns.');
});

it('escapes Markdown table breakers and HTML-like content', () => {
const markdown = exportDictionaryMarkdown(
[
{
id: 'danger',
type: 'tableNode',
position: { x: 0, y: 0 },
data: {
title: 'orders|<script>\nnext',
comment: '<b>note</b>',
badges: { pk: false, fk: false },
columns: [
{
column_name: 'name|x',
data_type: 'text',
is_pk: false,
is_not_null: false,
column_comment: 'see [docs](javascript:alert(1))',
example_value: '<img src=x onerror=alert(1)>',
},
],
},
},
],
[],
);

expect(markdown).toContain('## Table: orders\\|&lt;script&gt; next (&lt;b&gt;note&lt;/b&gt;)');
expect(markdown).toContain('name\\|x');
expect(markdown).toContain('see \\[docs\\]\\(javascript:alert\\(1\\)\\)');
expect(markdown).toContain('&lt;img src=x onerror=alert\\(1\\)&gt;');
expect(markdown).not.toContain('<script>');
expect(markdown).not.toContain('<img');
});

it('handles empty Markdown exports', () => {
expect(exportDictionaryMarkdown([], edges)).toBe('# Data Dictionary\n\nNo tables found.');
});
});
2 changes: 2 additions & 0 deletions frontend/src/erd/export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import type { IndexRecommendation } from './cardinality';
import type { ForeignKeyEdgeData, TableNodeData } from './convert';
import { sourceColumnHandleId, targetColumnHandleId } from './handleUtils';

export * from './exportDataDictionary';

type SnapshotJson = {
relations?: Array<{ relation_oid: number; schema_name: string; relation_name: string; relation_kind: string; relation_comment?: string | null }>
columns?: Array<{ relation_oid: number; column_name: string; data_type: string; is_not_null: boolean; example_value?: string | number | boolean | null }>
Expand Down
Loading
Loading