🎨 Palette: [접근성] 대시보드 동적 필터링 및 스크린 리더 환경 개선#315
Conversation
- 검색 필터가 변경될 때 스크린 리더가 인지할 수 있도록 테이블 컨테이너에 `aria-live="polite"` 추가 - `role="button"`이 부여된 테이블 행(`<tr>`)이 자식 텍스트를 마스킹하는 현상을 방지하기 위해 컨텍스트(심각도, 메시지, 파일)를 포함하는 동적 `aria-label` 템플릿 적용
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head3b1c0ed0f047a1ea721adb013cf46697ad57873a. -
Head SHA:
3b1c0ed0f047a1ea721adb013cf46697ad57873a -
Workflow run: 29441890096
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_dashboard_core.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_dashboard_core.py"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_dashboard_core.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_dashboard_core.py"]
R2 --> V2["targeted test run"]
|
- 검색 필터가 변경될 때 스크린 리더가 인지할 수 있도록 테이블 컨테이너에 `aria-live="polite"` 추가 - `role="button"`이 부여된 테이블 행(`<tr>`)이 자식 텍스트를 마스킹하는 현상을 방지하기 위해 컨텍스트(심각도, 메시지, 파일)를 포함하는 동적 `aria-label` 템플릿 적용
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head0715a1e97ee24a20a29c0428b16e47f33de9463c. -
Head SHA:
0715a1e97ee24a20a29c0428b16e47f33de9463c -
Workflow run: 29442909267
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_dashboard_core.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_dashboard_core.py"]
R2 --> V2["targeted test run"]
- 검색 필터가 변경될 때 스크린 리더가 인지할 수 있도록 테이블 컨테이너에 `aria-live="polite"` 추가 - `role="button"`이 부여된 테이블 행(`<tr>`)이 자식 텍스트를 마스킹하는 현상을 방지하기 위해 컨텍스트(심각도, 메시지, 파일)를 포함하는 동적 `aria-label` 템플릿 적용
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head16a4a006bc2054ee694acdd8a98fb756cb0e4582. -
Head SHA:
16a4a006bc2054ee694acdd8a98fb756cb0e4582 -
Workflow run: 29443678467
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_dashboard_core.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_dashboard_core.py"]
R2 --> V2["targeted test run"]
- 검색 필터가 변경될 때 스크린 리더가 인지할 수 있도록 테이블 컨테이너에 `aria-live="polite"` 추가 - `role="button"`이 부여된 테이블 행(`<tr>`)이 자식 텍스트를 마스킹하는 현상을 방지하기 위해 컨텍스트(심각도, 메시지, 파일)를 포함하는 동적 `aria-label` 템플릿 적용
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head2710cd735374fbc0c72af3402be4e8e7070fba82. -
Head SHA:
2710cd735374fbc0c72af3402be4e8e7070fba82 -
Workflow run: 29444574304
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_dashboard_core.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_dashboard_core.py"]
R2 --> V2["targeted test run"]
1 participant
💡 What: 대시보드 내 검색/필터 결과 테이블 컨테이너에
aria-live="polite"를 추가하고, 클릭 가능한 테이블 행(<tr>)의aria-label을 하드코딩된 텍스트 대신 심각도, 메시지, 파일 경로를 포함하도록 동적으로 변경했습니다. 테스트의 문자열 검증도 이에 맞춰 업데이트했습니다.🎯 Why: 스크린 리더 환경에서 사용자가 검색이나 필터링을 변경할 때 결과가 동적으로 업데이트되는 것을 인지하지 못하는 문제가 있었습니다. 또한,
<tr>요소에role="button"을 주게 되면 일부 스크린 리더가 하위 텍스트(메시지, 파일명 등)를 무시하고 덮어써버려 시각 장애가 있는 사용자가 해당 행이 어떤 오류 정보를 담고 있는지 알 수 없는 심각한 접근성 결함이 있었습니다.📸 Before/After: 시각적 변화 없음 (순수 HTML/ARIA 마크업 개선)
♿ Accessibility: 키보드 내비게이션 및 스크린 리더 사용자의 컨텍스트 인지도를 대폭 향상시켰습니다. 이제 필터 결과 변경을 안내받을 수 있고, 각 결과 행의 내용을 명확히 음성으로 전달받을 수 있습니다.
PR created automatically by Jules for task 4716071409393440446 started by @seonghobae