Better error logging on event failure#450
Open
jakequade-pc wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the usefulness of unhandled event error messages in EventEmitter.emit(...) by including additional context when the thrown value doesn’t have an error.message.
Changes:
- Updated the fallback “Unhandled error” message construction to include serialized error context when
.messageis unavailable. - (Formatting-only) No functional change in the closing brace at EOF.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| // At least give some kind of context to the user | ||
| var err = new Error('Unhandled error.' + (er ? ' (' + er.message + ')' : '')); | ||
| var err = new Error('Unhandled error.' + (er && er.message ? ' (' + er.message + ')' : JSON.stringify(er))); |
Author
|
@vladconstructor this is a minor one but would help with some errors we're getting where the message is just |
esezen
reviewed
May 12, 2026
extended serialisation Co-authored-by: Enes Kutay SEZEN <eneskutaysezen@gmail.com>
Author
|
Cool - makes sense. Thanks for your time @esezen 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're getting
Unhandled error. (undefined), which isn't super helpful. This PR retains the current logic (er.message is used when it exists), otherwise stringify the error and send it back as-is.