Skip to content

Update with latest changes to wikipedia script#1

Open
ccoreilly wants to merge 1 commit into
Connum:masterfrom
ccoreilly:master
Open

Update with latest changes to wikipedia script#1
ccoreilly wants to merge 1 commit into
Connum:masterfrom
ccoreilly:master

Conversation

@ccoreilly

Copy link
Copy Markdown

I updated the scripts with the latest changes back in November for a personal project but forgot to open a PR.

Opening now in case you're interested.

@Connum

Connum commented Aug 8, 2021

Copy link
Copy Markdown
Owner

So sorry for not reacting to this earlier, I totally missed that notification! Thanks so much for your contribution, let me take a look at it and I'll merge it!

@Connum

Connum commented Aug 9, 2021

Copy link
Copy Markdown
Owner

Just to be sure: Did you take those changes from the module of the Catalan Wiktionary? https://ca.wiktionary.org/w/index.php?title=M%C3%B2dul:ca-pron/AFI&action=history
Because the script on the English language Wiktionary doesn't seem to contain those additions yet: https://en.wiktionary.org/w/index.php?title=Module:ca-IPA&action=history
Do you remember the exact date of the last change that you ported over? It looks like there were even more additions made meanwhile and I want to make sure to catch everything.

@ccoreilly

Copy link
Copy Markdown
Author

I picked the changes from the Catalan Wiktionary for sure, but I don't remember the exact date, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants