Add reusable file upload decode helper#797
Draft
gontzess wants to merge 2 commits into
Draft
Conversation
gontzess
force-pushed
the
gontzess/file-upload-decode-helper
branch
from
b0266c1 to
49479c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Callers outside mapstructure need the SDK's file-upload decode behavior without duplicating base64 and data URL parsing. The helper uses explicit modes so path reads are opt-in rather than inferred from arbitrary strings.
What this changes
Adds DecodeFileUploadValue with content-only and path-only modes, plus an optional decoded-size limit for content mode.
Reuses the helper from FileUploadDecodeHook to keep existing hook behavior.
Keeps data URL handling limited to application/json base64 and adds focused tests.
Validation
go test -tags=baton_lambda_support -v ./pkg/field
go vet -tags=baton_lambda_support ./pkg/field
golangci-lint run --timeout=3m ./pkg/field (blocked locally: no go files to analyze before linting)