nhi: emit APP_REGISTRATION on JumpCloud apps (NHI Phase-1 K3)#29
Merged
Conversation
Contributor
Connector PR Review: nhi: emit APP_REGISTRATION on JumpCloud apps (NHI Phase-1 K3)Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThis PR adds a Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
c1-squire-dev
Bot
force-pushed
the
nhi/emit-credential-type
branch
from
c3a9eb6 to
836b788
Compare
JumpCloud applications are SSO application connectors that hold their own SSO config/credentials, so they are non-human identities of the app-registration type. Emit NonHumanIdentityTrait with NHI_TYPE_APP_REGISTRATION and detail "jumpcloud.application" on each app resource. Bumps baton-sdk to v0.11.0 for the WithNHIType helper / NonHumanIdentityTrait (interim self-bump per NHI RFC D-345; rebases after the fleet SDK bump). Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
…archived (v0.4.5) and can't resolve NonHumanIdentityTrait Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
c1-squire-dev
Bot
force-pushed
the
nhi/emit-credential-type
branch
from
0817333 to
508e50e
Compare
pquerna
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Emit the NHI Phase-1 K3 spine value on JumpCloud
appresources: each application now carries aNonHumanIdentityTraitwithNHI_TYPE_APP_REGISTRATIONand axis-2 detailjumpcloud.application.JumpCloud applications are SSO application connectors (SAML/OIDC) that hold their own SSO configuration and credentials — i.e. they are non-human identities of the app-registration type, matching the NHI RFC v6 §6 row 11 classification (
app TRAIT_APP → APP_REGISTRATION, Class A / classification-add).Scope (per NHI RFC v6 §6, JumpCloud row)
app→APP_REGISTRATION. Class A: the connector already syncs theappresource type; this PR just emits the new spine value on data already in hand.pkg/connector/connector.go:79-85). This is Class B (under-syncing → would need a new syncer) and is intentionally out of scope for this Phase-1 classification-add PR.The synthetic "JumpCloud Administration" app (
adminAppID) is a grant-container pseudo-resource, not a real SSO application registration / NHI, so it is deliberately left unclassified.SDK bump
Bumps
baton-sdkto v0.11.0 for theresource.WithNHITypehelper and theNonHumanIdentityTrait/NhiTypeenum. Interim self-bump per NHI RFC D-345; will rebase onto the fleet-wide SDK bump.Testing
go build ./...— passesgo test ./...— passesgolangci-lint run ./pkg/connector/...— 0 issues🛰️ Built with pqprime.