Skip to content

Add exclusion group#161

Open
MarcusGoldschmidt wants to merge 3 commits into
mainfrom
goldschmidt/exclusion-group
Open

Add exclusion group#161
MarcusGoldschmidt wants to merge 3 commits into
mainfrom
goldschmidt/exclusion-group

Conversation

@MarcusGoldschmidt
Copy link
Copy Markdown

No description provided.

@MarcusGoldschmidt MarcusGoldschmidt requested a review from a team May 20, 2026 18:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

testing update

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@MarcusGoldschmidt MarcusGoldschmidt force-pushed the goldschmidt/exclusion-group branch from 6cd4484 to 9ce815d Compare May 21, 2026 21:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Connector PR Review: Add exclusion group

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR adds an EntitlementExclusionGroup annotation to the repository static entitlements, grouping the five permission levels (pull, triage, push, maintain, admin) so that a principal can hold only one permission level per repository. The ordering follows the natural privilege escalation (pull=0 through admin=4), push is marked as the default, and the group is scoped per resource. The implementation is correct and consistent with the SDK's exclusion group support added in the v0.9.20 bump from the prior commits on this branch. No security or correctness issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@MarcusGoldschmidt MarcusGoldschmidt force-pushed the goldschmidt/exclusion-group branch from 5647f39 to e3bf9d3 Compare May 28, 2026 17:11
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants