runtime: harden stdin validation and JSON parsing#2
Merged
Conversation
65f2e3f to
670be6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base SHA:
15b5dc3a22c190d1eb18e25ce41de320d12a3b62Candidate SHA:
670be6a641306eabefac7ecc5081921b19de2e49Summary
pathvalues before path predicates run, so Windows-style paths are evaluated with the same segment semantics as slash paths.--stdinmode, keeping stdout reserved for verdict JSONL and reporting policy lint/self-test failures on stderr.BrokenPipewhen validation exits before reading input.Validation
cargo test --test integration stdin_rejects_failed_policy_self_tests_before_streaming_verdicts --locked: passed after fixing the Linux CI BrokenPipe reprocargo fmt --all -- --check: passedgit diff --check: passedcargo clippy --all-targets --locked -- -D warnings: passedcargo test --all --locked: passed (78 library tests, 25 integration tests, 3 parser robustness tests, 1 doctest)cargo build --release --locked: passedcargo build --locked: passedBarbican compatibility
Frozen dependency revisions tested:
15b5dc3a22c190d1eb18e25ce41de320d12a3b62670be6a641306eabefac7ecc5081921b19de2e4973acbe17b9d47b5b195d17c9629a5b767588616889409673b1943460f3262011418d085844de697ed7b60697df3f1c37319e636268a46355b6bbd607v24.15.011.13.0rustc 1.95.0 (59807616e 2026-04-14)cargo 1.95.0 (f2d3ce0bd 2026-03-21)Build order used for the frozen Barbican workspace:
cargo build --lockedpassedcargo build --lockedpassednpm cipassed;npm run buildpassednpm cipassed;npm run buildpassednpm cipassed;npm run buildpassedBaseline Barbican verification:
BARBICAN_WARDEN=<base-warden.exe> npm run verifyrun_shell/git statusreached downstream exactly oncetools/call, the allowedgit statuscallbarbicanandcapability_echoreports validated against agent-gov-coreCandidate Barbican verification:
BARBICAN_WARDEN=<candidate-warden.exe> npm run verifyrun_shell/git statusreached downstream exactly oncetools/call, the allowedgit statuscallbarbicanandcapability_echoreports validated against agent-gov-coreNo source or tracked files remain modified in the temporary
barbican,agent-gov-core, orCapabilityEchocheckouts after the compatibility run.