Fix "error on warning" behavior in CI#1386
Closed
j-c-c wants to merge 6 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1386 +/- ##
========================================
Coverage 88.26% 88.26%
========================================
Files 135 135
Lines 14663 14663
========================================
Hits 12942 12942
Misses 1721 1721 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…warnings that should (and should not) error in CI.
j-c-c
force-pushed
the
fix_warning_handling
branch
from
ab1f800 to
092c512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1375
The new behavior still errors on Python warnings but ignores
UserWarnings triggered from within our test modules. This means expectedUserWarnings in our unit tests will not cause our CI to fail. We will still catchUserWarnings eminating from within the code base andDeprecationWarnings from anywhere.