Feature/editor improvements#68
Open
maciekswat wants to merge 5 commits into
Open
Conversation
fyffep
approved these changes
Jun 30, 2026
fyffep
left a comment
Collaborator
There was a problem hiding this comment.
Aside from the concern about auto-save, this looks good. I researched a few things about how Qscintilla handles key events.
|
|
||
| self.defaultConfigs["EnableAutoSave"] = True | ||
|
|
||
| self.defaultConfigs["AutoSaveInterval"] = 1000 |
Collaborator
There was a problem hiding this comment.
This may cause a performance degradation or a stuttering feeling while typing. I recommend changing it.
Options:
- Change the default to every 1 minute. While 5-10 minutes is more common in other software, Twedit mainly operates on small text files.
- Make Twedit autosave after every keystroke instead of using a time-based saver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few Improvements
Here is summary of the new settings dialog and it also whos new features - auto-match characters and autosave