Grant JavaFX native access to silence Java 25 launch warnings#99
Merged
Merged
Conversation
JavaFX loads its native libraries via System::load, which on Java 25 prints a restricted-method warning and will be blocked outright in a future release. Add --enable-native-access=javafx.graphics,javafx.media, javafx.web alongside the existing --add-modules in every launcher (Linux/Mac/Windows scripts) and in the jpackage cfg/wrapper generators so packaged bundles stay in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Java 25, launching any GUI app (BEAUti, AppLauncher, etc.) prints:
JavaFX loads its native libraries via
System::load. Without native access explicitly granted, Java 25 warns — and a future release will block the call outright, which would break the GUI.Fix
Add
--enable-native-access=javafx.graphics,javafx.media,javafx.webnext to the existing--add-modules ...javafx...in every launcher:release/Linux/linuxbin/*release/Mac/macbin/*release/Windows/bat/*.cfg/ wrapper-.appgenerators (release/Mac/build-sign-dmg.sh,release/Windows/assemble-bundle.sh) so packaged bundles stay in sync with the static scripts.All three modules listed load native code and are guaranteed resolved (
javafx.web → javafx.media → javafx.graphics), so no "Unknown module" warning is introduced. Targeting all three (rather than justjavafx.graphics) prevents the same warning resurfacing from WebView/media later.Reported by Remco testing the Linux user bundle.