Include source jar in BEAST.base and BEAST.app package zips#100
Merged
Conversation
Match the BEAST2 package layout by shipping the module sources at the zip root as <PackageName>.src.jar (BEAST.base.src.jar / BEAST.app.src.jar), alongside version.xml. The -sources.jar is already produced by maven-source-plugin (jar-no-fork) in the package phase, ordered before the assembly execution, so each descriptor just copies it in and renames it. This is the name/location PackageHealthChecker.checkSourceCode() and the legacy installer already expect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ship the module sources inside the
BEAST.baseandBEAST.apppackage zips, matching the previous BEAST2 layout (requested by Remco).The source jar is placed at the zip root following the BEAST2 convention
<PackageName>.src.jar:How
maven-source-plugin(jar-no-fork) already produces a-sources.jarfor every module in thepackagephase, ordered before the assembly execution. So eachsrc/assembly/package.xmljust adds a<file>entry that copies that jar to the zip root and renames it to<PackageName>.src.jar— no new build steps.This is exactly the name and location that
PackageHealthChecker.checkSourceCode()and the legacy installer inBeastLauncheralready look for (source jar/zip at the package top level), so it satisfies the health check too. The src jar rides along automatically when the release scripts copy these zips into the bundle — no release-script changes needed.Verified
Built both modules and confirmed the zips contain the src jar at the root:
BEAST.base.src.jar(401.javafiles) andBEAST.app.src.jar(197.javafiles).