Upgrade GitHub Actions runner images to windows-2025#805
Open
Arlodotexe wants to merge 5 commits into
Open
Conversation
Avid29
previously approved these changes
May 15, 2026
Member
Author
|
Found the background info and original source of the bug for the disk space issue here. The mistake was made on Oct 2nd 2025 under https://github.com/CommunityToolkit/Windows/pull/737/files. Per the comments from @michael-hawker in the PR/Issue on this, we intended to keep the "large" runner wherever it was used, but the change here doesn't reflect that. It looks like the bad change has persisted unnoticed since then. The fix here is now certain and should be simple, I'll push that up in a moment. |
…lable" This reverts commit 2da2c9c.
Member
Author
|
Closing and re-opening to hopefully rekick CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR #803 intended to fully upgrade us to the
windows-2025runners and has been reviewed by a frequent contributor, closed and merged intomain.Problem
This was surfaced by @Avid29 in the #community-toolkit - Targeting .NET 10 thread on Discord after bringing in the #803 work to unblock #791.
The broken CI problem only appears on #791 and not on
mainbecause surfacing it requires bumping our minimum msbuild version to at least 18.0 and it requires bumping the runner (v17.0 is not included onwindows-2025).Some small but obvious edits were missed and required a follow up PR to fix.
Solution
Corrections have been made. Small PR.