Skip to content

fix: enable compiled Source binding to resolve XamlC XC0025 in TodoApp.MAUI #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianhall merged 2 commits into from
Jul 10, 2026
Merged

fix: enable compiled Source binding to resolve XamlC XC0025 in TodoApp.MAUI #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4dc26
fix: enable compiled Source binding to resolve XamlC XC0025 in TodoAp…
Jul 10, 2026
754276c
Merge branch 'main' into issues/517
adrianhall Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/todoapp/TodoApp.MAUI/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
Completed="OnAddItemEntryCompleted"
Placeholder="Enter Todo Item Text"
ReturnCommand="{Binding AddItemCommand}"
ReturnCommandParameter="{Binding Text, Source={x:Reference addItemEntry}}"
ReturnCommandParameter="{Binding Text, Source={x:Reference addItemEntry}, x:DataType=Entry}"
Style="{StaticResource addItemEntry}" />
</Grid>
</Border>
Expand Down
12 changes: 12 additions & 0 deletions samples/todoapp/TodoApp.MAUI/TodoApp.MAUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,18 @@
See https://github.com/CommunityToolkit/Datasync/issues/521.
-->
<SuppressTrimAnalysisWarnings Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">true</SuppressTrimAnalysisWarnings>

<!--
MainPage.xaml has one binding (Entry.ReturnCommandParameter) that sets an explicit
Source={x:Reference ...} instead of relying on the page's BindingContext. By default,
XamlC skips compiling any binding with an explicit Source, falling back to slower
reflection-based binding and emitting an XC0025 warning. Opting into this project-wide
flag lets XamlC compile that binding too, now that it's annotated with the correct
x:DataType for its Source (see MainPage.xaml). This project has no other Source-based
bindings, so there's no risk of newly-surfaced x:DataType mismatches elsewhere.
See https://github.com/CommunityToolkit/Datasync/issues/517.
-->
<MauiEnableXamlCBindingWithSourceCompilation>true</MauiEnableXamlCBindingWithSourceCompilation>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading