Skip to content

fix: CS8604 nullable warning in TodoApp.Avalonia LoggingHandler #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianhall merged 5 commits into from
Jul 10, 2026
Merged

fix: CS8604 nullable warning in TodoApp.Avalonia LoggingHandler #544

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9942b80
fix: CS8604 nullable warning in TodoApp.Avalonia LoggingHandler
TemRevil Jul 10, 2026
674403c
Merge branch 'main' into fix/avalonia-logginghandler-nullable
adrianhall Jul 10, 2026
63d107e
fix: assert instead of skip on null content in LoggingHandler
TemRevil Jul 10, 2026
a4ea060
Merge remote-tracking branch 'fork/fix/avalonia-logginghandler-nullable'
TemRevil Jul 10, 2026
14c6c08
Merge branch 'main' into fix/avalonia-logginghandler-nullable
adrianhall Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions samples/todoapp/TodoApp.Avalonia/TodoApp.Avalonia/Services/LoggingHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
return response;
}

private static async Task WriteContentAsync(HttpContent content, CancellationToken cancellationToken = default)
private static async Task WriteContentAsync(HttpContent? content, CancellationToken cancellationToken = default)
{
if (content != null)
{
Debug.WriteLine($"[HTTP] >>> {await content.ReadAsStringAsync(cancellationToken)}");
}
Debug.Assert(content != null, "Request/response content should never be null here.");
Debug.WriteLine($"[HTTP] >>> {await content.ReadAsStringAsync(cancellationToken)}");
}
}
Loading