Sync upstream CodexBar through 261bad66#47
Merged
Conversation
* feat: restructure settings * feat: redesign settings as System Settings-style split view Replace the toolbar-tab settings window with a NavigationSplitView: the sidebar lists app panes (colored icon chips) plus every provider as a first-class row with brand icon, status dot, search, drag reorder, and context-menu enable/disable. Panes are rebuilt on native grouped Forms; content regroups by intent (General: system/refresh/ notifications/shortcut, Display: menu bar/menu/cost/animations, Advanced: CLI/privacy/diagnostics). The per-tab window resize machinery and hand-rolled card components are deleted, the window is one fixed size, and the selected pane persists across launches. PR screenshots move to the artifact store instead of the repo. * test: allow Italian 'Privacy' as intentionally unchanged * test: retarget sidebar localization markers to PreferencesSidebar * feat: align provider detail pane with grouped-form design Rebuild ProviderDetailView as a native grouped Form: header row with brand icon, refresh, and enable switch; info as LabeledContent rows; full-width usage bars; native picker rows; Accounts and quota-warning blocks become real form sections. Drop the label-width machinery and the redundant State row. Give the sidebar provider count breathing room and make the settings window resizable (min 780x520). * test: use #require for defaults suite in selection tests * feat: make provider credential and field blocks real form sections Token accounts, settings fields, and organizations render as their own grouped-form sections with proper headers/footers; text-field placeholders move inside the fields (prompt + labelsHidden) instead of leaking into a left label column. Primary add action joins the links row; organization toggles become switches.
Co-authored-by: pavbar <pavlo@barzdun.com>
* Group menu usage rows * docs: credit grouped usage rows --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream range
Syncs
steipete/CodexBarmainfrom44f0949b69bb705c43c3685ef23d7a16f1539763to261bad662bc9157f8a5e4e48269cd3642ab4c612.No open
upstream-syncissue existed when the automation started; this PR handles the live upstream tail directly.Risk review
Reviewed as medium/high risk because the range touches settings UI architecture, status/menu usage rows, reset-boundary usage refresh behavior, release preflight metadata, localization, and widget project metadata.
Focused review areas:
QuotaKit adaptations
UPSTREAM_MONITOR_BASE/UPSTREAM_SYNC_DATE; left shipped QuotaKit marketing/mobile/build versions unchanged.CHANGELOG.md.Validation
git diff --cached --checkswift test --filter 'PreferencesSelectionTests|PreferencesPaneSmokeTests|UsageStoreResetBoundaryRefreshTests'swift test --filter 'ProvidersPaneCoverageTests|TerminalAppTests|StatusMenuNativeSectionSpacingTests|MenuCardViewRecyclingTests|LocalizationLanguageCatalogTests|UserFacingLocalizationCoverageTests'PARSER_LINT_BASE=origin/main ./Scripts/lint.sh lintswift buildxcodebuild -project WidgetExtension/CodexBarWidgetExtension.xcodeproj -scheme CodexBarWidgetExtension -destination 'platform=macOS' -derivedDataPath /tmp/quotakit-widget-validation CODE_SIGNING_ALLOWED=NO buildmake testThe macOS widget build succeeded. Xcode emitted a local CoreSimulator version warning while loading simulator devices, but the macOS build completed successfully.