compute_branching_ratio was messed up#8
Open
chase-kimball wants to merge 13 commits into
Open
Conversation
Owner
|
Hi @chase-kimball, it looks like there's a conflict. There also seem to be a few commits that we merged the other day. Can you make sure you merge in Also, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order in the call to einsum was off. self.first_generation_mass_ratio needs to be last in order to match the order of integration & self.retention_fraction. Luckily this doesn't change the qualitative results. But odds ratios have moved around a bit