product-service chart: split /health & /ready probes, externalize config - #2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
product-service chart: split /health & /ready probes, externalize config#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…fig via env/secret
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
product-serviceHelm chart to match the newly containerized Product service (see quickapp-microservices companion PR): distinct liveness/readiness probes, container port 8080, and env-var/secret-based configuration instead of hardcoded values.Probes —
healthCheckinvalues.yamlsplit from a singlepath/portinto:deployment.yamlnow pointslivenessProbe→/healthandreadinessProbe→/ready.Ports — new
containerPort: 8080(matches the image'sASPNETCORE_HTTP_PORTS).service.portstays5004(stable cluster address); ServicetargetPortnow resolves tocontainerPort.Config externalization — deployment injects env vars; DB password is pulled from an existing Secret rather than stored in values:
New
config.database.*(host/port/name/username/existingSecret/passwordKey) andextraEnv: []values. No credentials in the chart.Verification
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/3d95e4a548134c9e9f8ee60fd2657ba0
Requested by: @mbatchelor81