Skip to content

product-service chart: split /health & /ready probes, externalize config - #2

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783961794-product-service-health
Open

product-service chart: split /health & /ready probes, externalize config#2
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1783961794-product-service-health

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Updates the product-service Helm chart to match the newly containerized Product service (see quickapp-microservices companion PR): distinct liveness/readiness probes, container port 8080, and env-var/secret-based configuration instead of hardcoded values.

ProbeshealthCheck in values.yaml split from a single path/port into:

healthCheck:
  liveness:  { path: /health, initialDelaySeconds: 15, periodSeconds: 10 }
  readiness: { path: /ready,  initialDelaySeconds: 5,  periodSeconds: 5 }

deployment.yaml now points livenessProbe/health and readinessProbe/ready.

Ports — new containerPort: 8080 (matches the image's ASPNETCORE_HTTP_PORTS). service.port stays 5004 (stable cluster address); Service targetPort now resolves to containerPort.

Config externalization — deployment injects env vars; DB password is pulled from an existing Secret rather than stored in values:

env:
  - ASPNETCORE_ENVIRONMENT / ASPNETCORE_HTTP_PORTS
  - ConnectionStrings__DefaultConnection: "Host=...;...;Password=$(DB_PASSWORD)"
  - DB_PASSWORD: valueFrom.secretKeyRef(name=product-service-db, key=password)

New config.database.* (host/port/name/username/existingSecret/passwordKey) and extraEnv: [] values. No credentials in the chart.

Verification

helm lint charts/product-service                                  # passes
helm template product-service charts/product-service -f environments/{dev,staging,prod}/values.yaml   # renders
yamllint charts/product-service/... environments/                 # only pre-existing document-start warnings

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/3d95e4a548134c9e9f8ee60fd2657ba0
Requested by: @mbatchelor81

@mbatchelor81 mbatchelor81 self-assigned this Jul 13, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant