Tar seek rework#1
Open
DmitriyKorchemkin wants to merge 3 commits into
Open
Conversation
DmitriyKorchemkin
force-pushed
the
tar-seek-rework
branch
from
ea6f6ca to
152fee8
Compare
avostrik
approved these changes
Apr 14, 2026
DmitriyKorchemkin
force-pushed
the
tar-seek-rework
branch
from
152fee8 to
94437ae
Compare
|
Rebased on top of v3.8.7 and merged to master, this one can be declined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix tar seek implementation.
a. Fixed cmake files to make library buildable standalone again
b. Added tests for TAR seek:
- TAR file constructed in memory
- User-provided tar file (via
TAR_SEEK_ARCHIVE_PATH)c. Fixed implementation of tar seek till it started working on the latest recordings after transition to TAR.
- Removed assumption that data starts 512 bytes after header
- Added explicit offset to the start of data entry to avoid re-parsing header on seek to start
- Added restoring of the state on seek.
With those changes, looped playback appears to be working on
TAR-based recording files (that is, after seek to start the CAN stream is not mangled at random offset anymore)