fix(web): export web API and lazy-load pospider#165
Open
muxia0396 wants to merge 1 commit into
Open
Conversation
muxia0396
marked this pull request as ready for review
July 15, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
office.webfrom the top-levelofficepackagepospiderso an optional dependency does not breakimport officepospiderWhy
office/api/web.pyalready definesurl2ebook(), and the repository example callsoffice.web.url2ebook(...), butoffice/__init__.pydoes not exportweb. As a result, the documented top-level usage raisesAttributeError.Importing
pospiderat module load time would also make the entireofficepackage fail to import when that optional package is unavailable. The publishedpospider 0.0.1package currently does not expose the expectedurl.url2ebookAPI, so the loader now reports that incompatibility explicitly instead of leaking an unclear attribute error.Impact
Users can access the web namespace consistently through
office.web. Environments that do not use web conversion can still importofficewithout installingpospider, while callers receive actionable errors when the dependency is missing or incompatible.Validation
All 5 related tests pass.