fix: corrected tick lookup for swing playback#2702
Merged
Conversation
Danielku15
force-pushed
the
feature/swing-lookup
branch
2 times, most recently
from
5bf5ed6 to
9d0c95b
Compare
Danielku15
force-pushed
the
feature/swing-lookup
branch
from
9d0c95b to
cd3c02f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2657
Proposed changes
There were some incorrect usages of playbackStart and playbackDuration where we should actually use the midi tick lookup.
Especially in swing cases this could lead to wrong playback ranges and seeks.
Checklist
Further details